Loop and make new instance object every iteration c#

Question

so I am trying to make a loop in which I create a new instance of an object every time it loops: something like this.

Client client = new Client(session);
client.Connect(server);

while (true) {
    client.SendPacket(new Craft.Net.CreativeInventoryActionPacket(-1, new Craft.Net.ItemStack((short)19, (sbyte)1)));

    client.Disconnect ("Generic");

    System.Threading.Thread.Sleep(3000);

    //obviously I cannot do this, because there is already an object named client.
    Client client = new Client(session);

    client.Connect(server);
}

How would I go about doing this? I need to make a NEW instance of MinecraftClient, I cannot reuse the old one after I do client.Disconnect.

jason · Accepted Answer · 2013-05-29 01:32:07Z

4

The simplest thing that works is to change

Client client = new Client(session);

to

client = new Client(session);

That said, I think there's a cleaner approach. Start with:

while(true) {
    Client client = new Client(session);
    client.Connect(server);
    client.SendPacket (new Craft.Net.CreativeInventoryActionPacket(-1, new Craft.Net.ItemStack((short)19, (sbyte)1)));
    client.Disconnect ("Generic");
    System.Threading.Thread.Sleep(3000);
}

Now factor that out into a method:

private void ConnectAndDoStuff() {
    Client client = new Client(session);
    client.Connect(server);
    client.SendPacket (new Craft.Net.CreativeInventoryActionPacket(-1, new Craft.Net.ItemStack((short)19, (sbyte)1)));
    client.Disconnect ("Generic");
    System.Threading.Thread.Sleep(3000); 
}

And then:

while(true) { this.ConnectAndDoStuff() }

answered May 29, 2013 at 1:32

jason

243k35 gold badges436 silver badges532 bronze badges

Sign up to request clarification or add additional context in comments.

11 Comments

Umar F Khawaja Over a year ago

+1, but of course you need a way to break out of the while loop, which I presume is being handled separately?

Kirk Woll Over a year ago

I'm not sure that factoring out a 5-line method (that presumably has one caller) is ipso facto an improvement.

Dimitar Dimitrov Over a year ago

@KirkWoll Actually, it's a great improvement. The number of lines are irrelevant, I'd probably split it even more -> One method for connecting and one for DoingStuff

Kirk Woll Over a year ago

@DimitarDimitrov, I don't think splitting functionality because of the ability to name discrete ideas necessarily outweighs the cost of obscuring the implementation of the logic.

Dimitar Dimitrov Over a year ago

@KirkWoll Not sure exactly what you mean, but if anything encapsulating the implementation in a method (preferably smaller methods) increases the readability and maintainability of the code. That's just in principle, not necessary in this particular scenario. Also I should include a big "IMHO" somewhere there.

|

Sam Leach · Accepted Answer · 2013-05-29 01:36:27Z

1

Create the instance in the loop every time you start again.

while (true) {
    Client client = new Client(session);
    client.Connect(server);
    client.SendPacket (new Craft.Net.CreativeInventoryActionPacket(-1, new Craft.Net.ItemStack((short)19, (sbyte)1)));
    client.Disconnect ("Generic");

    System.Threading.Thread.Sleep(3000);
}

edited May 29, 2013 at 1:36

Sam Leach

13k10 gold badges49 silver badges73 bronze badges

answered May 29, 2013 at 1:33

Chief Wiggum

2,9642 gold badges34 silver badges46 bronze badges

Comments

sa_ddam213 · Accepted Answer · 2013-05-29 01:31:55Z

0

If you just want to recreate the client object just remove the Type definition

    Client client = new Client(session);
    client.Connect(server);
    while (true)
    {
        client.SendPacket (new Craft.Net.CreativeInventoryActionPacket(-1, new Craft.Net.ItemStack((short)19, (sbyte)1)));
        client.Disconnect ("Generic");
        System.Threading.Thread.Sleep(3000);
        client = new Client(session); 
        client.Connect(server);
    }

answered May 29, 2013 at 1:31

sa_ddam213

43.7k7 gold badges105 silver badges112 bronze badges

Collectives™ on Stack Overflow

Loop and make new instance object every iteration c#

3 Answers 3

11 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

11 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related