Python Boolean as argument in a function

Question

I have a function that needs input as True/False that will be fed in from another function. I would like to know what is the best practice to do this. Here is the example I am trying:

def feedBool(self, x):

    x = a_function_assigns_values_of_x(x = x)
    if x=="val1" or x == "val2" :
      inp = True
    else
      inp = False

    feedingBool(self, inp)
    return

def feedingBool(self, inp) :
    if inp :
      do_something
    else :
      dont_do_something
    return

dawg · Accepted Answer · 2013-05-29 19:43:15Z

1

You can do:

def feedBool(self, x):
    x = a_function_assigns_values_of_x(x = x)    
    feedingBool(self, bool(x=="val1" or x == "val2"))

Or, as pointed out in the comments:

def feedBool(self, x):
    x = a_function_assigns_values_of_x(x = x)    
    feedingBool(self, x in ("val1","val2"))

answered May 29, 2013 at 19:43

dawg

105k24 gold badges142 silver badges217 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Andbdrew Over a year ago

You shouldn't need the bool there

jamylak Over a year ago

No need to convert to bool

rob mayoff Over a year ago

There's no need to call the bool constructor. Also, you can say x in ("val1", "val2").

mogul · Accepted Answer · 2013-05-29 19:45:36Z

1

why not just:

inp = x in ("val1", "val2")

of cause it can be compacted even more directly in the call to the next function, but that will be at the cost of some readability, imho.

answered May 29, 2013 at 19:45

mogul

4,5431 gold badge20 silver badges23 bronze badges

Comments

Jochen Ritzel · Accepted Answer · 2013-05-29 19:48:45Z

0

You usually put the test in a function and spell out the consequence:

def test(x):
    # aka `return x in ("val1", "val2")` but thats another story
    if x=="val1" or x == "val2" :
      res = True
    else
      res = False    
    return res

def dostuff(inp):
    # i guess this function is supposed to do something with inp
    x = a_function_assigns_values_of_x(inp)
    if test(x):
      do_something
    else :
      dont_do_something

dostuff(inp)

answered May 29, 2013 at 19:48

Jochen Ritzel

108k33 gold badges205 silver badges195 bronze badges

Collectives™ on Stack Overflow

Python Boolean as argument in a function

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related