C# Mysql threads

Question

Currently I have a global static MySqlConnection connection; which is shared across threads (bad, I know) but I lock while opening new connections or closing old ones and only do so if the thread is the first that has been created or the last that was left (I also determine this by a static int MySqlConnected).

Currently it gets mixed up for some reason, what is the problem with my setup?

What do you mean it gets mixed up? Could you explain what is your error? I have a feeling about it — Steve
– Steve, Commented May 30, 2013 at 11:42
@Steve the problem is that not the right query is executed for some reason, I write the values right before sending them to the query and they are completely different, I also tried running the query outside of a thread and it worked perfectly. — user2372936
– user2372936, Commented May 30, 2013 at 12:17
Look up .net connection pooling. You are doing this well wrong. — Tony Hopkinson
– Tony Hopkinson, Commented May 30, 2013 at 16:19

axel_c · Accepted Answer · 2013-05-30 13:52:11Z

2

Why are you doing that anyway?

The .NET runtime is already quite efficient at keeping a pool of connections and re-using them as needed transparently in a safe and hassle-free way. It looks to me like you're trying to accomplish something that's already provided by the framework. When you need to execute a query, just open a new connection and use it. The runtime will take care of all the rest for you.

Additionally, using threads plus static variables is a great recipe for trouble, resulting in code that often fails in subtle, non-obvious ways. You seem to be implementing some kind of home-grown locking mechanism which is very easy to get wrong. So unless you're very experienced with multithreaded scenarios, I'd stay away from this kind of thing.

answered May 30, 2013 at 13:52

axel_c

6,8012 gold badges32 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

C# Mysql threads

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related