Calling function from button not working for html created using javascript

Question

I am using javascript to create html page , but not able to call some function on button click .

var alernative = "plot1";
var buttonvalue= "mybutton";
 function callme()
 {alert("hello");}   

 $('#' + alernative).html('<div><input style="float:right;" type="button" value="' + buttonvalue+ '" onclick="' +   callme() + '";></div>');

In above code , creating a button and giving its value and calling function onclick of button , but when the page loads it shows alert (that should not happen) and it is not alerting on button click .

Hoping for Suggestion or some help .

Petr Čihula · Accepted Answer · 2013-05-30 14:10:15Z

6

You need to pass the function name as a part of the string:

$('#' + alernative).html('<div><input style="float:right;" type="button" value="' + buttonvalue+ '" onclick="callme();"></div>');

answered May 30, 2013 at 14:10

Petr Čihula

9977 silver badges10 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user1260967 Over a year ago

Thnxs for ur reply .... but am getting "callme is not defined" while i had defined callme function as" function callme() { alert("wed"); } " before writing the html line . ...... any suggestion where i am doing mistake @petr

Petr Čihula Over a year ago

@user1260967: I'd love to help you further but this piece of code you provided doesn't show anything that might potentionally go wrong. Something else is happening down the lines, try to edit your post for showing us more.

Niccolò Campolungo · Accepted Answer · 2013-05-30 14:17:07Z

0

It is a bad practice to write HTML with strings, DOM exists for one reason!

var input = $('<input/>', {
    type: "button",
    style: "float: right",
    value: buttonValue
}),
    element = $('<div/>').append(input);
input.click(function () {
    callme();
});
$('#test').html(element);

answered May 30, 2013 at 14:17

Niccolò Campolungo

12k4 gold badges35 silver badges40 bronze badges

Collectives™ on Stack Overflow

Calling function from button not working for html created using javascript

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related