Extracting variable from onchange event handler for use in other functions

Question

I have an event handler listening for a change in a dropdown and setting the value of a variable. I have declared the variable as global i.e. outside of any functions, and then set the value on change. However, once it has changed I need to be able to pick up the variable in other functions (not within the even handler). How can i 'extract' it from within the event handler? I've tried to return it but no luck - here is the code:

$(document).on('change', 'select#search_subject', function () {
    if ($('#sBar3').show()) {
        $('#sBar3').hide();
    }
    var subject = $('#search_subject>option:selected').text();
    var id = $('#search_subject>option:selected').val();
    ajaxSubject(subject, '#sBar3');
    return subject;
});
console.log(subject);

the log just shows 'empty string' and I'm baffled. If possible I dont want to rejig the code to include everything within the event handler (there's lots of Google Map generating code in there and it will make for a pain) - i just need to get the subject variable out of the event handler if that makes sense - Thanks

You said you declared the variable in global scope. Then don't declare a local variable with the same name, omit var. Of course the console.log(subject); will still show undefined since the event hasn't happened yet at the moment the statement is executed. — Felix Kling
– Felix Kling, Commented May 31, 2013 at 20:07
thanks for helping a total noob understand a little more felix - cheers — Mobaz
– Mobaz, Commented May 31, 2013 at 20:12

Evan Davis · Accepted Answer · 2013-05-31 20:09:16Z

5

By using the var keyword, you're creating a new local variable, which you're then assigning the subject text to. If you've already defined subject in the global scope, then your assignment line should simply be:

subject = $('#search_subject>option:selected').text();

edited May 31, 2013 at 20:09

Evan Davis

36.7k7 gold badges53 silver badges58 bronze badges

answered May 31, 2013 at 20:08

grandivory

6393 silver badges6 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

mplungjan · Accepted Answer · 2013-05-31 20:20:27Z

0

If the select is not created later, then this would be simpler code after you remove the var that makes subject local

$("#search_subject").on('change',function () {
  $('#sBar3').toggle();
  subject = $('option:selected',this).text();
  var id = $(this).val(); // not used?
  ajaxSubject(subject, '#sBar3');
  window.console && console.log(subject);   
  return subject;
});

answered May 31, 2013 at 20:20

mplungjan

180k29 gold badges183 silver badges246 bronze badges

Collectives™ on Stack Overflow

Extracting variable from onchange event handler for use in other functions

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related