JavaScript & CakePHP: how to get this simple script working?

Question

I'm trying to use echo $this->Html->script('dynamic_emails'); at the very beginning of the View file (ctp) to load some JavaScript, but it is currently not working. It does work if I explicitly put in place <script type="text/javascript" src="/mysite/js/dynamic_emails.js"></script> at the end of the View file.

Here is the code. I'm suspecting that function is not declared properly.. Any ideas?

dynamic_emails.js:

var mytextbox = document.getElementById('mytext');
var mydropdown = document.getElementById('dropdown');

mydropdown.onchange = function(){
     mytextbox.value = 'some text';
}

If you're running getElementById() before the id is rendered, it's not going to find it. Try putting the echo $this->Html->script() script line at the bottom of the layout (not view) just to see if it works that way. Or even at the bottom of the view should work. (though ideally this should be going into some kind of "onload" event) — Costa
– Costa, Commented Jun 4, 2013 at 0:14

Kevin Gorjan · Accepted Answer · 2013-06-04 10:52:00Z

1

Depending on your version on cake your js should be in app/webroot/js/dynamic_email.js try putting it there and then including it with the helper , or just include it directly

Also it is usually best practice to include js at the bottom of your files and even better at the bottom of your layout

If you are already using something like cake this is probably a medium to large project in wich case you would really benefit from using something like jquery

answered Jun 4, 2013 at 10:52

Kevin Gorjan

1,3321 gold badge17 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

toby1kenobi · Accepted Answer · 2013-06-04 10:23:23Z

1

Does the code emitted by the helper result in a valid script tag (pointing correctly to your Javascript file), is the Javascript file downloaded by the browser? It's worth checking that the output is as you're expecting.

To be honest, I'm not sure that using the CakePHP helper here really gains you that much anyway, you could just include the full script tag.

answered Jun 4, 2013 at 10:23

toby1kenobi

1,7011 gold badge14 silver badges27 bronze badges

Collectives™ on Stack Overflow

JavaScript & CakePHP: how to get this simple script working?

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related