MultiThreading with instance variable java

Question

I have a class like,

Class A extends B {

   String test = "";
   String first = "";

   public void testMethod() {
      new Thread() {
         public void run() {
           testThreadMethod();
         }
      }.start();

   }

   public void testThreadMethod() {
     System.out.println(first + " " + test);
   }
}

The above class compiles fine. But in run time, the error is thrown in system.out.println() saying "invalid thread access".

Is there any wrong in the code. Accessing instance variables in multithread not allowed? Is there any way to access the instance variable inside the thread?

Thanks in advance.

EDITED NEW: To Reproduce the problem

import org.eclipse.swt.SWT;
import org.eclipse.swt.events.SelectionAdapter;
import org.eclipse.swt.events.SelectionEvent;
import org.eclipse.swt.layout.GridData;
import org.eclipse.swt.layout.GridLayout;
import org.eclipse.swt.widgets.Button;
import org.eclipse.swt.widgets.Composite;
import org.eclipse.swt.widgets.Display;
import org.eclipse.swt.widgets.Label;
import org.eclipse.swt.widgets.Shell;
import org.eclipse.swt.widgets.Text;
import org.eclipse.ui.part.ViewPart;

public class SWTView extends ViewPart{
    public static Display display;
    public static Shell shell;
    static Text sampleText;
    static String testField1 = "";
    static String firstField2 = "";
    public static void main(String[] args) {
        display = new Display();
        shell = new Shell(display);
        // Create a new Gridlayout with 2 columns 
        // where the 2 column do not have the 
        // same size
        GridLayout layout = new GridLayout(2, false);
        // set the layout of the shell
        shell.setLayout(layout);
        // Create a label and a button

        sampleText = new Text(shell, SWT.NONE);
        Label label = new Label(shell, SWT.NONE);
        label.setText("A label");
        Button button = new Button(shell, SWT.PUSH);
        button.setText("Press Me");

        // Create a new label that will spam two columns
        label = new Label(shell, SWT.BORDER);
        label.setText("This is a label");
        // Create new layout data
        GridData data = new GridData(GridData.FILL, 
                GridData.BEGINNING, true, false, 2, 1);
        label.setLayoutData(data);

        // Create a new label which is used as a separator
        label = new Label(shell, SWT.SEPARATOR | SWT.HORIZONTAL);
        // Create new layout data
        data = new GridData(GridData.FILL, GridData.BEGINNING, true,
                false, 2, 1);
        data.horizontalSpan=2;
        label.setLayoutData(data);

        // Create a right aligned button
        Button b = new Button(shell, SWT.PUSH);
        b.setText("New Button");
        b.addSelectionListener(new SelectionAdapter() {
            public void widgetSelected(SelectionEvent e) {
                new Thread() {
                    public void run() {
                        printInstanceVariables();
                    }
                }.start();
                //showProgressBar() ---> // This is been implemented in another file which will shoe progress bar
            }
        });

        data = new GridData(GridData.END, GridData.BEGINNING, false,
                false, 2, 1);
        b.setLayoutData(data);


        shell.pack();
        shell.open();
        while (!shell.isDisposed()) {
            if (!display.readAndDispatch())
                display.sleep();
        }
        display.dispose();
    }

    public static void printInstanceVariables() {
        System.out.println("Text entered is :: " +sampleText.getText());
        System.out.println("test Field 1 is :: " + testField1);
        System.out.println("first Field 2 is :: " + firstField2);
    }


    @Override
    public void createPartControl(Composite arg0) {
        // TODO Auto-generated method stub

    }

    @Override
    public void setFocus() {
      shell.setFocus();
    }

}

The above code will throw invalid thread acesses ecpection @ printInstanceVariables() first system.out.println()

Answer: Got it.. It is because of accessing the component Text inside the thread in printInstanceVariables(). When i pass this component as paramter, everything works fine. Thanks for all you answers.

Is there a stack trace with the error? Please post the entire error message. There isn't anything special that you must do to access instance fields from a thread. — John B
– John B, Commented Jun 4, 2013 at 10:34
@cmbaxter Why? There is no need. The program looks fine so the problem is in the code that has not been shown yet... — assylias
– assylias, Commented Jun 4, 2013 at 10:35

assylias · Accepted Answer · 2013-06-04 10:43:23Z

3

This program compiles and executes as expected (it prints a space and a new line). Your problem is somewhere else:

public class Test {

    public static void main(String[] args) throws Exception {
        A a = new A();
        a.testMethod();
    }

    static class A {

        String test = "";
        String first = "";

        public void testMethod() {
            new Thread() {
                public void run() {
                    testThreadMethod();
                }
            }.start();
        }

        public void testThreadMethod() {
            System.out.println(first + " " + test);
        }
    }
}

answered Jun 4, 2013 at 10:43

community wiki

assylias

Sign up to request clarification or add additional context in comments.

1 Comment

xagyg Over a year ago

Correct. I got the same result.

Sumit Desai · Accepted Answer · 2013-06-04 10:42:18Z

1

I tried your code without extending class B and its working fine. What does your class B contain? Is there really any need to extend class B?

answered Jun 4, 2013 at 10:42

Sumit Desai

1,78015 silver badges31 bronze badges

3 Comments

xagyg Over a year ago

Good question. @Rock123 - what does B look like?

AJJ Over a year ago

I am executing this class with SWT view part. the class B in question is the ViewPart class and class A is my view. The class A will be executed when the view is loaded and the new thread inside the class will be executed on click of a button in the view. Since class A is not executed by new Thread, the instance variables are not accessible in new thread??? please let me know on this.

John B Over a year ago

@Rock123 The new Thread instance is an anonymous instance of A and therefore DOES have access to the fields of A. We have said this MULTIPLE times. Something ELSE is the issue.

BrookLeet · Accepted Answer · 2013-06-04 10:58:22Z

-2

anonymous inner class is only allowed access FINAL member variable. this is JVM specification. i doubt why there is no warning when your code be compiled.

in fact i could get nothing out put when run these code. is there something wrong?

i rewrite the codes, test it and find enter image description here

it can't access a member variable when the thread in anonymous inner class. please see the output from eclipse.

enter image description here

edited Jun 4, 2013 at 10:58

answered Jun 4, 2013 at 10:38

BrookLeet

582 bronze badges

1 Comment

John B Over a year ago

I believe you are thinking of final parameters. This is not true of fields.

Collectives™ on Stack Overflow

MultiThreading with instance variable java

3 Answers 3

1 Comment

3 Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

3 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related