How to use valid? method on an array in rails 3

Question

I am working on an app in rails 3.

I have several records that i want to save to my database. I am trying to make sure that all the objects in an array (the records are stored in an array) are valid before saving. The Owner model validates the presence of name and email. In the rails console, I have tried the following:

@owner = Array.new
=> []

@owner[0] = Owner.new (name:"peter", email:"[email protected]")
=> returns object

@owner[1] = Owner.new (name:"fred", email:"[email protected]")
=> returns object

@owner[2] = Owner.new (name:"", email:"")
=> returns object

@owner[0].valid?
=> true

@owner[1].valid?
=> true

@owner[2].valid?
=> false

@owner.each { |t| t.valid? }
=> returns an array like this: [object1, object2, object3]. I would expect something like this instead: [true,true,false]

I dont understand why the .valid? method works fine if I individually check the elements of the array using @owner[i], but doesnt work correctly if I'm using .each to iterate through the array. Anybody know what might be the problem?

What I am trying to do is achieve something like this:

(@owner.each { |t| t.valid? }).all?

To make sure that each record is valid, then I can proceed to save them.

Thanks

doesterr · Accepted Answer · 2013-06-06 01:04:20Z

10

Each does not return an array of valid? values. You probably want either:

(@owner.collect { |t| t.valid? }).all?

or

(@owner.all? { |t| t.valid? })

The examples can also be written as:

@owner.collect(&:valid?).all?

or

@owner.all?(&:valid?)

edited Jun 6, 2013 at 1:04

doesterr

3,96522 silver badges27 bronze badges

answered Jun 5, 2013 at 20:35

patrickmcgraw

2,51514 silver badges9 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

David Hemmat Over a year ago

Thank you, both options worked perfectly. I have to read up on the differences between each and collect.

Alex D Over a year ago

There's not much to read up about... each just runs the block for each element of the Array, map or collect runs the block for each element of the Array AND collects the return value for each iteration of the block into a new Array.

Collectives™ on Stack Overflow

How to use valid? method on an array in rails 3

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related