Calling image in this PHP function

Question

I am trying to call images in this function, but they all come up as question marks. Could anyone tell me what I did wrong?

if(!$currentvotes) $currentvotes = 0;
echo '<div class="vote vote'.$id.'"><span>'.$currentvotes.'</span>';
if($user_ID && !$alreadyVoted) echo '<br /><a post="'.$id.'" user="'.$user_ID.'"><img src="/images/thumbsup.png" WIDTH=25 HEIGHT=25></a>';
if($user_ID && $alreadyVoted) echo '<br /><span class="voted"><img src="/images/thumbsup.png" WIDTH=25 HEIGHT=25></span>';
echo '</div>';
if(!$user_ID) echo '<div class="signup"><p><a style="color:#4ec1f3;" href="'.get_bloginfo('url').'/wp-login.php?action=register"><img src="/images/thumbsup.png" WIDTH=25 HEIGHT=25></p></div>';
}

You can't 'call' an image. You can call functions, methods, procedures, code but images are data and can't be 'called'. — Patashu
– Patashu, Commented Jun 6, 2013 at 0:18
i believe thats the browsers way of saying that the images are not where your html says they are — user557846
– user557846, Commented Jun 6, 2013 at 0:19
I suppose the path you are using has to be absolute eg (http://.../images/...). Or use base tag in your head in html <base href="yourdomain" target="_blank"> — bksi
– bksi, Commented Jun 6, 2013 at 0:29

Saturnix · Accepted Answer · 2013-06-06 00:30:30Z

1

I am trying to call images in this function

As in the comments:

You can't 'call' an image. You can call functions, methods, procedures, code but images are data and can't be 'called'. – Patashu

[...] they all come up as question marks

Right click on those question marks: choose "open image in new window". You should see a new page with a 404 error. Look at the link of that page: that's the path where your image is supposed to be (if you're getting a 404 error it simply means they are not there). Create the folder images and upload the file thumbsup.png. Now reload the page.

answered Jun 6, 2013 at 0:30

Saturnix

10.6k19 gold badges70 silver badges129 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

user2457773 Over a year ago

This place is awesome. You were right. The path to the image was wrong. Thanks so much man! Dumb mistake!

Saturnix Over a year ago

if this question solved the issue, would you mind mark it as correct? Thanks.

user2457773 Over a year ago

Yup! As soon as I figure out how haha

bksi · Accepted Answer · 2013-06-06 00:43:48Z

1

I suppose the path you are using has to be absolute eg (http://.../images/myimage.jpg) instead /images/myimage.jpg. This is common issue when you write custom code (don't use standard framework) and use .htaccess to rewrite urls.

You can set basepath as constant so you can easy change it if you switch domains.

define("BASE_PATH", "http://mydomain.com");

and then in code use it:

BASE_PATH."/images/myimage.jpg"

Or use base tag in your head in html

<base href="http://www.yourdomain" target="_blank">

And as Saturnix said in his answer you should have folder named "images" and filename you put in src.

edited Jun 6, 2013 at 0:43

answered Jun 6, 2013 at 0:30

bksi

1,6251 gold badge24 silver badges45 bronze badges

4 Comments

Saturnix Over a year ago

img src doesn't necessarily need absolute path. OP's just ignoring, probably, the correct path to the image file.

bksi Over a year ago

I had issues like this, and absolute path was the resolution

Saturnix Over a year ago

absolute path is not a good solution: the day you'll switch domain you'll have to reconfigure all of your pages.

bksi Over a year ago

I agree, but i gave second resolution with setting base path

Nigel Alderton · Accepted Answer · 2013-06-06 00:56:25Z

1

If an image can't be found in the location you specify in your HTML, the browser will display a broken image link marker, maybe like one of these;

Chrome
IE10
Firefox 10

Each browser has its own marker. Maybe your browser uses a question mark to indicate a broken image link.

answered Jun 6, 2013 at 0:56

Nigel Alderton

2,4062 gold badges26 silver badges56 bronze badges

2 Comments

Nigel Alderton Over a year ago

No problem! And take no notice of the people who downvote questions initially. You asked a perfectly reasonable question. What browser are you using?

user2457773 Over a year ago

I'm using Safari mostly, but I also check everything in Chrome, Opera, Firefox and Internet Explorer to be sure :P

Collectives™ on Stack Overflow

Calling image in this PHP function

3 Answers 3

3 Comments

4 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

4 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related