Int() Conversions not working right in python

Question

So I'm making a python Module to create and save data for an in-game character. the the class is Character and goes as follows:

#!/usr/bin/python
import os
import re

class Character:
    storage = None
    health = None
    strength = None
    xp = None

    def __init__(self,stg):
        os.chdir('/Users/alex/Desktop/Python/Support/Character')
        storage = stg
        f = open(storage)
        #health index = 0
        #strength index = 1
        #xp index = 2
        string = f.read()
        finder = re.compile('/n')
        stats = finder.split(string)
        health = int(stats[0])
        strength = int(stats[1])
        xp = int(stats[2])  
        f.close

    def adjHealth(self,amount):
        health += amount

    def adjStrength(self,amount):
        strength += amount

    def adjXp(self,amount):
        xp += amount

    def save(self):
        os.chdir('/Users/alex/Desktop/Python/Support/Character')
        stats = [str(health),str(strength),str(xp)]
        f = open(storage,'w')
        f.writelines(stats)

Whenever I do this command from the python interpreter:

>>> import character as ch
>>> ch.Character('jimmy')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/alex/Desktop/Python/Modules/character.py", line 22, in __init__
health = int(stats[0])
ValueError: invalid literal for int() with base 10: '10\n10\n0\n'

It comes up with that ValueError. It should be splitting the string returned by f.read() into ['10','10','0',''] right?
So why can't I convert '10' into an int? I'm kind of new to reqular expressions.

The following two strings mean completely different things: \n and /n. — Chris Eberle
– Chris Eberle, Commented Jun 7, 2013 at 2:08

Chris Eberle · Accepted Answer · 2013-06-07 02:10:00Z

1

It's your regular expression. The following will look for the literal character / followed by n:

finder = re.compile('/n')

This on the other hand will look for newlines:

finder = re.compile('\n')

answered Jun 7, 2013 at 2:10

Chris Eberle

48.9k12 gold badges85 silver badges123 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

lvc · Accepted Answer · 2013-06-07 02:42:19Z

0

The problem is with your regex, but there is no particular need for regex here - using the capabilities provided by file objects, all of this (corrected) code:

string = f.read()
finder = re.compile('\n')
stats = finder.split(string)

can be reduced to the one-line:

stats = f.readlines()

Or, to have it without the trailing newlines:

f.read().splitlines()

Also, note that you're not actually closing the file - you need to call the close method, not just mention it. But the preferred way to do this is a with statement:

with open(stg) as f:
    stats = f.readlines()

This ensures that the file gets closed as soon as you're done with it, even if something goes wrong while reading it.

Your code also has another bug that will bite you sooner rather than later:

health = int(stats[0])

creates a new function-local variable called health - it doesn't assign it to the one you've set to None up in the class body. You can set that one by assigning to Character.health, but you almost certainly want self.health instead. This will bite you in your adj* methods, which will, as written, result in an error.

You would also end up removing those variables from the class body - they don't behave like C++ or Java attribute declarations (which Python doesn't require or, without metaclass magic, even support), and don't end up being used.

edited Jun 7, 2013 at 2:42

answered Jun 7, 2013 at 2:23

lvc

35.2k10 gold badges76 silver badges100 bronze badges

2 Comments

Awalrod Over a year ago

Thanks, but the f.readlines() function returns the values WITH the \n character at the end of each string in the list. I would have to strip out the newline characters. But you are right about everything else. Thanks a ton.

lvc Over a year ago

@Awalrod in that case, you still don't need regex - f.read().splitlines().

Collectives™ on Stack Overflow

Int() Conversions not working right in python

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related