php foreach error handling in function

Question

I have a function which performs a foreach loop on an array from a database.

see foreach ($teamarray AS $key => $value){$teamgo .= $value[1]." ".$value[2]."<br/>";

Problem is, sometimes there may be no data set, which throws an error when the loop hits that field.

How can i catch/suppress this error?

function GetUnsubmitted($coach){
  $push .= "<div id=unsubmitted><h2>Check which event/teams you want to process and click submit</h2>";
  $push .= "<form action=\"submit.php\" method=POST>";
  $result = mysql_query("SELECT * FROM `ptable` WHERE coach = '$_SESSION[username]' AND status = '1' ORDER BY status ASC") or trigger_error(mysql_error()); 
  while($row = mysql_fetch_array($result)){ 
    foreach($row AS $key => $value) { $row[$key] = stripslashes($value); } 
    $id = $row['id'];
    $teampre = $row['team'];
    $eventpre = $row['event'];
    $statuspre = $row['status'];
    $eventarray = DecodeEvent($eventpre);
    $event = $eventarray[0];
    $cat = $eventarray[1];
    $subcat = $eventarray[2];
    $division = $eventarray[3];
    $type = $eventarray[4];

    $teamarray = DecodeTeam($teampre);

    $price = GetPrice($type, "nat");
    $teamcount = count($teamarray);
    $total = $price * $teamcount;

    $teamgo = "";

    foreach ($teamarray AS $key => $value){
      $teamgo .= $value[1]." ".$value[2]."<br/>";

      if($statuspre == "1"){
        $statuscolor = "#FFCC99";
        $statusmsg = "unsubmitted <a href=delsub.php?id=$id onClick=\"return confirm('Are you sure you want to delete this submission?');\"><img src=images/del.png border=0 />";
      } elseif($statuspre == "2"){
        $statuscolor = "#FFCC66";
        $statusmsg = "awaiting confirmation";
      } elseif($statuspre == "3"){
        $statuscolor = "#66CC66";
        $statusmsg = "confirmed";
      }  
    }   
    $push .= "<div id=submission><div id=event style=\"background-color:$statuscolor;\"><h1>$event</h1><span id=status>$statusmsg</span></div><div id=subinfo><a href=\"#\" onClick=\"if($(this).next('div').css('display') == 'none') { $(this).next('div').show('fast'); } else { $(this).next('div').hide('fast'); } return false;\"><span id=dropdown><img src=images/expand.png border=0></span><h2>$cat >> $subcat >> $division >> $type</h2></a> <div id=team style=\"display:none;\">$teamgo<br />$price - $total<div id=controls></div></div></div></div>";
    $pid .= $id;
    $rtotal .= "$total,"; 
  } 


  $stotal = explode(",", $rtotal);
  $gtotal = array_sum($stotal);

  $push .= "<div style=\"text-align:right;\"><div id=total>Total - <em>$gtotal</em></div><br><input type=image src=images/paynow.png alt=\"Pay Now\"></form> <a href=submit2.php?$pid&$pidarray><img src=images/mailfax.png width=138px height=41px border=0></a></div></div>";     

  return $push;
}

If possible id like it to say "no team selected" and stop.

merkushin · Accepted Answer · 2017-12-05 12:55:07Z

4

You can write so:

foreach ((array)$teamarray as $key => $value) {
    $teamgo .= $value[1] . " " . $value[2] . "<br/>";
    //...
}

foreach expects array. So the really correct way is to ensure that you deal with array before try to iterate, like this:

if (is_array($teamarray) && count($teamarray)) {
    foreach ((array)$teamarray as $key => $value) {
        $teamgo .= $value[1] . " " . $value[2] . "<br/>";
        //...
    }
}

You also can check is_iterable since PHP 7.1.

edited Dec 5, 2017 at 12:55

answered Nov 9, 2009 at 9:21

merkushin

4819 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

hakre · Accepted Answer · 2012-10-06 18:14:18Z

2

if ($array) {
    foreach ($array as $k => $v) {
        ...
    }
} else {
    echo 'No team selected';
    // exit from loop
}

Your exit from loop will be a "return", or a "break n" (n is the levels to break for) or continue... it depends on your logic.

edited Oct 6, 2012 at 18:14

hakre

200k55 gold badges454 silver badges865 bronze badges

answered Nov 9, 2009 at 9:20

Palantir

24.2k11 gold badges79 silver badges88 bronze badges

Comments

Dave Archer · Accepted Answer · 2009-11-09 09:20:52Z

1

if ($value !== null && count($value) >= 3) {


$teamgo .= $value[1] . $value[2]
}

answered Nov 9, 2009 at 9:20

Dave Archer

3,05021 silver badges23 bronze badges

Comments

Kaze no Koe · Accepted Answer · 2009-11-09 09:23:52Z

1

foreach($row AS $key => $value) { 
    if ($value) {
        $row[$key] = stripslashes($value);
    } 
}

And:

foreach ($teamarray AS $key => $value){
    if ($value && sizeof($value) > 2) {
        $teamgo .= $value[1] . $value[2]
    }
}

Is this it?

answered Nov 9, 2009 at 9:23

Kaze no Koe

3,2541 gold badge24 silver badges22 bronze badges

Comments

Gumbo · Accepted Answer · 2009-11-09 09:30:12Z

1

Just do a test if $teamarray actually is an array:

if (is_array($teamarray)) {
    foreach ($teamarray as $key => $value) {
        // …
    }
}

answered Nov 9, 2009 at 9:30

Gumbo

657k112 gold badges792 silver badges852 bronze badges

Comments

jmoz · Accepted Answer · 2009-11-09 12:23:48Z

1

Or you could do:

$teamarray = isset($teamarray) ? $teamarray : array();

Just prior to the loop in a nice tidy line, and it would ensure that you have the variable set to an empty array which would cause it to skip the foreach().

answered Nov 9, 2009 at 12:23

jmoz

8,0165 gold badges33 silver badges33 bronze badges

Collectives™ on Stack Overflow

php foreach error handling in function

6 Answers 6

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related