Ruby on Rails If...Else

Question

I have the following code:

<div class="category_name">
     <%= current_user %>
     <%= review.user.front_name %>
      <% if current_user.name = review.user.front_name %>
      <%= link_to "You", user_path(review.user) %> / <%= review.categories_list %>
      <% else %>
      <%= link_to review.user.front_name, user_path(review.user) %> / <%= review.categories_list %>
      <% end %>
    </div>

It renders something like:

Tom Murphy Bill Smith You / Films

Why is this happening?

<% if current_user.name = review.user.front_name %>

In other words, if Tom Murphy = Bill Smith...which it doesn't...shouldn't it go to the line AFTER the 'else'? That's what I want to happen.

its a silly mistake, used =instead of == . You are assigning instead of comparing — Muntasim
– Muntasim, Commented Jun 18, 2013 at 10:24

Muntasim · Accepted Answer · 2013-06-28 10:54:40Z

5

replace <% if current_user.name = review.user.front_name %> with

<% if current_user.name == review.user.front_name %>

you put =, you have to put ==

edited Jun 28, 2013 at 10:54

answered Jun 18, 2013 at 10:23

Muntasim

6,7963 gold badges49 silver badges70 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

CHarris Over a year ago

Thanks for all your help. They're all right, but just accepting this as it came in first. Isn't there also a '==='? What does that do?

Muntasim Over a year ago

regarding '===' The general definition of the triple equals is that it will return true if both parts are identical or if the right part is contained within the range of the left. 1 === 1 #true (1..3) === 2 #true There are some other impacts as well

Ganesh Kunwar · Accepted Answer · 2013-06-18 10:29:10Z

2

Just modify: <% if current_user.name = review.user.front_name %> to

<% if current_user.name == review.user.front_name %>

The == ( double equal) Test for equal value..

answered Jun 18, 2013 at 10:29

Ganesh Kunwar

2,6532 gold badges23 silver badges37 bronze badges

Comments

hrr · Accepted Answer · 2013-06-18 10:39:00Z

2

In Ruby to check equality you should use double equal signs (==).

Also - Currently you are comparing the names. You should compare the objects (User) to avoid mistakes or even worse (security breaches).

<% if current_user == review.user %>

edited Jun 18, 2013 at 10:39

answered Jun 18, 2013 at 10:24

hrr

1,6511 gold badge13 silver badges15 bronze badges

Comments

akbarbin · Accepted Answer · 2013-06-18 10:41:48Z

1

when you want to make conditional statement. you should compare your statement. for example:

if number == 10
   print "Variable is 10"
elsif number == "20"
   print "Variable is 20"
else
   print "Variable is something else"
end

on your case please change the line:

<% if current_user.name = review.user.front_name %>

change intoenter code here

<% if current_user.name == review.user.front_name %>

answered Jun 18, 2013 at 10:41

akbarbin

5,1051 gold badge31 silver badges31 bronze badges

Collectives™ on Stack Overflow

Ruby on Rails If...Else

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related