Input String not in correct format (Format Exception not handled)

Question

I am trying to parse the retried value from the database into double, long, or integer, but it throws a FormatException. I need your help.

In this code, I am trying to retrieve hours from the database and sum them to calculate total hours input into the database.

String hrs;
Double resultHrs=0;

while (oleDbDataReader1.Read())
{
    hrs = oleDbDataReader1["Hours"].ToString();
    double HRS = double.Parse(oleDbDataReader1["Hours"].ToString());
    resultHrs = resultHrs + HRS;
}// end while

Jon Skeet · Accepted Answer · 2013-06-18 16:53:00Z

2

Don't do the string conversion in the first place:

double hours = (double) oleDbDataReader1["Hours"];

Unless your value is actually a string in the database (in which case you should fix that) there's no reason to convert it into a string. (If it's not a type mapped to double, you should change what you cast it to, of course.)

EDIT: If it's non-numeric in the database, then you probably do need to use double.Parse - but you might want to specify the culture. For example, assuming they're all of the form "10.2" rather than "10,2" (as some cultures would use) you would want something like:

double hours = double.Parse((string) oleDbDataReader1["Hours"],
                            CultureInfo.InvariantCulture);

edited Jun 18, 2013 at 16:53

answered Jun 18, 2013 at 16:37

Jon Skeet

1.5m893 gold badges9.3k silver badges9.3k bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Jon Skeet Over a year ago

@AbeerIslam: Why is it text at all, if it's always meant to hold a number?

Abeer Islam Over a year ago

I had to cast it anyway while inputting the value into the database that was my reason for doing that however i have changed it anyway

Kzest · Accepted Answer · 2013-06-19 03:55:20Z

1

I use:

 HRS = oledbDataReader1.GetDouble(iColumn);

where iColumn is the column index in the query

edited Jun 19, 2013 at 3:55

answered Jun 18, 2013 at 16:42

Kzest

5363 silver badges4 bronze badges

Collectives™ on Stack Overflow

Input String not in correct format (Format Exception not handled)

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related