Call Javascript onClick not working

Question

         *@ JAVASCRIPT
             $(document).ready(function()
             {
             }
             )

             function videochange(url) {
                 alert(url)
             }

On the click of this button it wont hit the JavaScript function above. Any idea why? I really need to get that video.Value to a JavaScript function.....

 @foreach(var video in Model.VideoList)
        {           
            var url = video.Value;
         <input type="button" value="@video.Text" onclick="javascript:videochange(url);" />
            <br />
        }

Mark Withers · Accepted Answer · 2013-06-19 13:26:46Z

2

I would use JQuery. Assuming you've got version 1.7 or later, the following code should work. It also enforces a better separation between your markup and your JavaScript.

<div class="container">
  @foreach(var video in Model.VideoList) {           
    <input type="button" value="@video.Text" data-url="@video.Value" />
  }
</div>

<script>
  $(document).ready(function(){
    $('.container').on('click', 'input[type="button"]', function(){
      var url = $(this).attr('data-url');
      alert(url);
    });
  });
</script>

answered Jun 19, 2013 at 13:26

Mark Withers

1,4825 gold badges16 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

cHao Over a year ago

I'd probably add [data-url] to the button selector, so only buttons with a data-url get that click handler.

Mark Withers Over a year ago

@cHao Yeah, that's even better.

codingbiz · Accepted Answer · 2013-06-19 20:27:52Z

1

Try this

@foreach(var video in Model.VideoList)
{           
    var url = video.Value;
 <input type="button" value="@v.Value" onclick="@String.Format("videochange('{0}')", url)" />
    <br />
}

edited Jun 19, 2013 at 20:27

answered Jun 19, 2013 at 13:09

codingbiz

26.4k9 gold badges62 silver badges99 bronze badges

1 Comment

Corey Toolis Over a year ago

the funny thing is this worked at one point now its giving me the undetermined string constant again... and the second ' seems to not realize theres a first ' it makes the ); after count as the string.

Arun P Johny · Accepted Answer · 2013-06-19 13:15:15Z

1

Try

@foreach(var video in Model.VideoList) {           
    <input type="button" value="@video.Text" onclick="videochange('@video.Value');" />
    <br />
}

edited Jun 19, 2013 at 13:15

answered Jun 19, 2013 at 13:09

Arun P Johny

389k68 gold badges532 silver badges532 bronze badges

3 Comments

Arun P Johny Over a year ago

@CoreyToolis sorry updated, there was another error. onclick="javascript:videochange should be onclick="videochange

cHao Over a year ago

@ArunPJohny: The javascript: thing is ugly, but not a syntax error. It gets parsed as a label.

Corey Toolis Over a year ago

the funny thing is this worked at one point now its giving me the undetermined string constant again... and the second ' seems to not realize theres a first ' it makes the ); after count as the string.

Collectives™ on Stack Overflow

Call Javascript onClick not working

3 Answers 3

2 Comments

1 Comment

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

1 Comment

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related