NSMutable array adding entries?

Question

I am pretty new to objective-c and I am creating an app where records are held. I have tried to make an adding method when I click a save button though it doesn't save the data when you press the button or if it does it doesn't display it. The data is being shown in a tableView

here is the code for the save button:

-(void)savePatient:(id)sender {
LSAppDelegate *delegate = (LSAppDelegate *)[[UIApplication sharedApplication] delegate];
NSMutableArray *patients = delegate.patients;

UITextField *firstnameEntry = (UITextField *)[firstNameCell viewWithTag:777];
UITextField *surnameEntry = (UITextField *)[surnameNameCell viewWithTag:777];
UITextField *dobEntry = (UITextField *)[dobDateCell viewWithTag:777];
UITextField *homeNumberEntry = (UITextField *)[homeNumberCell viewWithTag:777];
UITextField *mobileNumberEntry = (UITextField *)[mobileNumberCell viewWithTag:777];
UITextField *emailAddressEntry = (UITextField *)[emailAddressCell viewWithTag:777];
UITextView *addressEntry = (UITextView *)[addressCell viewWithTag:777];

if (firstnameEntry.text.length > 0) {
    Patient *newPatient = [[Patient alloc] init];
    newPatient.patientName = firstnameEntry.text;
    newPatient.patientSurname = surnameEntry.text;
    newPatient.patientDoB = dobEntry.text;
    newPatient.patientHomeNumber = homeNumberEntry.text;
    newPatient.patientMobileNumber = mobileNumberEntry.text;
    newPatient.patientEmail = emailAddressEntry.text;
    newPatient.patientAddress = addressEntry.text;
    newPatient.patientPicture = nil;
    [patients addObject:newPatient];
    LSViewController *viewController = delegate.viewController;
    [viewController.tableView reloadData];
}
    [delegate.navController popViewControllerAnimated:YES];

}

I've found that the issue is here

if (firstnameEntry.text.length > 0) {

please say if you want any more code

Thanks in advance

Okay. So you have lines of code for the save button. And? If you click on the button, what happens? You don't say where you have difficulty. — El Tomato
– El Tomato, Commented Jun 21, 2013 at 17:54
You could try adding a couple breakpoints or NSLog statements in the savePatient method to see what the value of firstNameTextEntry.text is and see if it actually enters your if statement — mrosales
– mrosales, Commented Jun 21, 2013 at 18:16
This may be a dumb question, but are you using the tag 777 over and over in your actual code, or did you just put that in there when you added your code here? — Matt Becker
– Matt Becker, Commented Jun 21, 2013 at 20:05

Matt Hudson · Accepted Answer · 2013-06-23 22:25:30Z

3

You need to make sure that your delegate has the proper retain type and not copy as copy in the property returns an array and not an NSMutableArray.

Although your problem of loading data is probably a simple issue of not allocing/initing your array. It would be better to move your patients array to your local class.

Move this property from your delegate to your class.

@property (nonatomic, retain) NSMutableArray *patients;

Do not use copy and do not use NSArray. Also, you need to make sure that somewhere you are instantiating the mutable array. Preferably in the viewDidLoad function.

In your class, somewhere before this viewcontroller is created be sure you create the array.

self.patients = [[NSMutableArray alloc] init];

This assumes you're using ARC. If you're not using ARC be sure to release the array in the dealloc method.

Usually if data isn't coming across it's b/c your array is nil or an NSArray and not NSMutableArray.

I would also add breakpoints in your method above and make sure that your tableView is not nil and that your array is not nil.

edited Jun 23, 2013 at 22:25

answered Jun 21, 2013 at 18:03

Matt Hudson

7,3587 gold badges53 silver badges68 bronze badges

Sign up to request clarification or add additional context in comments.

10 Comments

Hive7 Over a year ago

would you like my app delegate files?

Abizern Over a year ago

This is a really bad idea. If you have a property that needs to be changed don't just make it mutable so that it can be changed from outside the class, you've just broken encapsulation.

Matt Hudson Over a year ago

@Abizem, I appreciate your comment. However, he asked why his data wasn't loading. The reason it isn't loading is b/c the array he is using isn't mutable or isn't alloced. I'm not going to refactor his code in order to answer a simple question. Also, you propose no solution to the problem. I gave him a practical solution.

Matt Hudson Over a year ago

And aside from that adding an array on your delegate is generally a poor idea as well. In fact most of your code @Hive7 is crap. So get cranking and eventually we'll answer your simple data loading question, but not until you understand encapsulation, inheritance, and polymorphism.

nemesis Over a year ago

@Inturbidus - actually that assumes not-ARC. self.patients = [NSMutableArray array]; assumes ARC.

|

Bassel Shawi · Accepted Answer · 2013-06-21 19:30:24Z

0

Are you sure that [viewController.tableView reloadData]; actually get executed, i seriously doubt it since you're on a different viewController, you could try to put the reloatData statement on the viewDidAppear event of your table controller view after you pop from the editing viewController.

answered Jun 21, 2013 at 19:30

Bassel Shawi

6144 gold badges11 silver badges29 bronze badges

1 Comment

Hive7 Over a year ago

I have imported it so I think so. do you know, if that is not happening, what to do

Collectives™ on Stack Overflow

NSMutable array adding entries?

2 Answers 2

10 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

10 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related