Calling a function as a function in javascript/jQuery

Question

I am wanting to know what is the quickest way below to repeat or give this "function" below a name so that I can call it within another function in the same document -> runThisFunction();

Code:

$('body').on("click", ".manufacturer_details_link", function (e) {
                e.preventDefault();

                var self = $(this);
                var id = self.data("id");

                var url = $("#manufacturers_table").data("infourl");

                var data_array = { 
                        id : id 
                    };

                ajaxCall(url, data_array, "rhs_info");

            });

jAndy · Accepted Answer · 2013-06-22 00:50:53Z

2

If I understood everything correct:

function bodyOnClick( e, optionalId ) {
    var nodeRef = optionalId ? document.getElementById( optionalId ) : this;

    if( typeof e === 'object' )
        e.preventDefault();

    var self = $(this);
    var id = nodeRef.data("id");

    var url = $("#manufacturers_table").data("infourl");

    var data_array = { 
        id : id 
    };

    ajaxCall(url, data_array, "rhs_info");
}

// ---

$('body').on("click", ".manufacturer_details_link", bodyOnClick );

// ---

bodyOnClick( 'someNodeID' );

But actually, calling bodyOnClick plain doesn't make much sense, since this would not reference any HTMLElement. So it only makes sense if you re-use the method on other event handlers, or explicitly call it like

~~bodyOnClick.call( someNodeReference );~~

edited Jun 22, 2013 at 0:50

answered Jun 22, 2013 at 0:41

jAndy

237k57 gold badges313 silver badges363 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Jess McKenzie Over a year ago

Thanks Andy, would I pass in an id as nodeRef?

mekwall Over a year ago

@JessMcKenzie No, it has to be an actual node. I.e. $("#foo")[0]

jAndy Over a year ago

@JessMcKenzie you could do that, but you would need to re-write the function for that, I edited the function to give you a basic example.

mekwall Over a year ago

@jAndy I'd suggest not reusing the bind handler, it makes for some unreadable code. I'd split them up into two functions, leaving the bind handler as a lamba function and calling the other function from within that one.

jAndy Over a year ago

@MarcusEkwall I guess I would agree in general. However, I think the answer here makes some good enough points and examples so ultimately OP and others will realize your note for themselfs :-)

Andreas Louv · Accepted Answer · 2013-06-22 00:45:48Z

0

You mean like this?

function someFunction(e){
    e.preventDefault();
    var id = $(this).data("id"),
        url = $("#manufacturers_table").data("infourl"),
        data_array = {id: id};
    ajaxCall(url, data_array, "rhs_info");
}
//$('.manufacturer_details_link').click(someFunction);

// changed, per feedback
$('.manufacturer_details_link').on('click', someFunction);

edited Jun 22, 2013 at 0:45

Andreas Louv

47.3k14 gold badges109 silver badges126 bronze badges

answered Jun 22, 2013 at 0:41

Brian Lewis

5,7191 gold badge23 silver badges28 bronze badges

1 Comment

mekwall Over a year ago

OP is using .on since it's a delegated bind. Don't change it unless you know it will work.

Collectives™ on Stack Overflow

Calling a function as a function in javascript/jQuery

2 Answers 2

5 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related