php while loop error db

Question

function DisplayPoints()
    {   

    $con = mysql_connect("localhost", "grame2_admin", "password") ;
    if (!$con) {
    die("Can not connected: " . mysql_error());
    }
    mysql_select_db("grame2_webpage",$con);
    $sql = "SELECT points FROM tablename WHERE username = $username";
    $myData = mysql_query($sql,$con);
    while($record = mysql_fetch_array($myData)){

It echo out info, that there is error in line 164, LINE ABOVE THIS.

    echo $record['points'] ;

    }
    mysql_close($con);

}

the main idea is to echo out INT from specific user in webpage. Please help! :)

IF you get an error you should post it here so that other user know what error you get and can help you — bish
– bish, Commented Jun 22, 2013 at 9:24
Thanks it doesnt show error now, but it doesnt show INT . I want to see it, what i'm doing wrong? — Emil Morris
– Emil Morris, Commented Jun 22, 2013 at 9:36
@EmilMorris Is it a complete code for that function? Where $username variable is defined? — peterm
– peterm, Commented Jun 22, 2013 at 9:52

peterm · Accepted Answer · 2013-06-22 10:19:47Z

1

Change

$sql = "SELECT points FROM tablename WHERE username = $username";

to

$sql = "SELECT points FROM tablename WHERE username = '$username'";
                                                      ^         ^

On a side note use prepared statements with either mysqli or PDO. mysql extension is deprecated and is no longer supported.

UPDATE The other problem is that your $username variable is not initialized. You probably need to pass it to your function as a parameter

function DisplayPoints($username) 
{
    ...
}

And when you call your function pass a value

DisplayPoints('user1');

or

$username = $_POST['username'];
// here should go code to validate and sanitize $username
DisplayPoints($username);

edited Jun 22, 2013 at 10:19

answered Jun 22, 2013 at 9:25

peterm

93k16 gold badges157 silver badges162 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

peterm Over a year ago

It's hard to tell from the code that you posted. Did you try to execute your query directly in mysql?

Emil Morris Over a year ago

forgive, but I did not understand what you mean by that

peterm Over a year ago

I mean did you try to execute the query SELECT points FROM tablename WHERE username = '<substitute with the value from $username' using phpmyadmin or mysql command line utility or any other client tool for mysql? You may not have a record with a username that is assigned to $username variable. Or $username variable can contain wrong value or contain no value.

Emil Morris Over a year ago

No I havent. Where i need to assign it- somewhere in phpmyamdin or in function DisplayPoints() code? and what i have to do to assign it? Mabe there is some tutorial in web that you know?

Emil Morris Over a year ago

HOLLLY SH*T! YOU ARE THE BEST, IT WORKED. BIG, BIG THANKS BRO, RESPECT. :) :) :)

Collectives™ on Stack Overflow

php while loop error db

1 Answer 1

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related