Getting java to save a HTML file

Question

I have code written in java that is grabbing the index page of a website, but when I try to save the file it saves a blank document.
Here is the code:

import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;
import java.net.URL;
import java.net.URLConnection;
import javax.swing.JOptionPane;
import java.io.*;

public class source {

   public static void main(String[] args) throws IOException {

    String filename;

    filename = JOptionPane.showInputDialog("Enter the site");
    PrintWriter outputFile = new PrintWriter("files\\"+filename+".html");

    URL url = new URL("http://"+filename);


    URLConnection con = url.openConnection();
    InputStream is =con.getInputStream();

    BufferedReader br = new BufferedReader(new InputStreamReader(is));

    String line = null;


    while ((line = br.readLine()) != null) {
        System.out.println(line);
        outputFile.println(line);
    }
    System.exit(0);
}
}

What am I doing wrong?
Is there anything that I need to add to save html?

Also, why do you need to call System.exit(0) at the last line of main? Your program will exit anyway. — MD Sayem Ahmed
– MD Sayem Ahmed, Commented Jul 3, 2013 at 5:24
Also, a try catch finally { if (outputfile!=null) outputfile.close() ... } will be fine — surfealokesea
– surfealokesea, Commented Jul 3, 2013 at 5:25
Or use Java 7 and its try-with-resources syntax. Seriously, who targets Java 6 anymore? — fluffy
– fluffy, Commented Jul 6, 2013 at 1:13

zEro · Accepted Answer · 2013-07-03 05:26:45Z

3

As far as I can see, only two things are missing here.

You failed to close the reader and writer.

Add these at the end.

br.close();
outputFile.close();

PS: It would help us help you, if we know the input as well.

answered Jul 3, 2013 at 5:26

zEro

1,27314 silver badges24 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jakub · Accepted Answer · 2013-07-09 17:55:11Z

1

Do not use System.exit(). It's practically never needed and definitely not here. As paulsm4 said, you're missing the outputFile.close() (br.close() won't matter here), so the writes aren't flushed to disk.

edited Jul 9, 2013 at 17:55

Jakub

20.5k8 gold badges67 silver badges93 bronze badges

answered Jul 3, 2013 at 5:24

Kayaman

73.8k6 gold badges91 silver badges128 bronze badges

Comments

Suresh Atta · Accepted Answer · 2013-07-03 05:24:19Z

0

You forgot to close / flush the data.

 BufferedReader br = new BufferedReader(new InputStreamReader(is));

    String line = null;


    while ((line = br.readLine()) != null) {
        System.out.println(line);
        outputFile.println(line);
    }
    br.close();

And your System.exit() causes Jvm to shutdown.

answered Jul 3, 2013 at 5:24

Suresh Atta

122k38 gold badges206 silver badges315 bronze badges

Collectives™ on Stack Overflow

Getting java to save a HTML file

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related