jquery change variable function not working

Question

Here is a sample of my code, i've removed the unnecessary parts. I've set a global variable recipient. It should be alert 1 but nothing is being alerted. What is the correct way to change a variable set outside a function? How do i solve this?

var recipient = 0;

$("#submit-button").click(function () {

    $.getJSON("/fetch.php?o=4&user=" + k, function (B) {
        $.each(B, function (index, result) {
            recipient = 1;

        })

    })

    if (recipient == 1) {
        alert("yes");
    }
})

possible duplicate of How to return the response from an AJAX call? — James Montagne
– James Montagne, Commented Jul 3, 2013 at 18:15

Adil · Accepted Answer · 2013-07-03 18:15:35Z

4

It is due to asyn call, put the condition in callback function instead of putting if after it. The call back is called after the click function finished execution.

var recipient = 0;      


$("#submit-button").click(function() {

  $.getJSON("/fetch.php?o=4&user=" + k, function(B) {
       $.each(B, function(index, result) {
            recipient = 1;    
       });
      if(recipient==1) {
         alert("yes");
      }
   });
});

answered Jul 3, 2013 at 18:15

Adil

148k25 gold badges217 silver badges207 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Austin Brunkhorst · Accepted Answer · 2013-07-03 18:15:51Z

1

You're checking to see if recipient is 1 before the JSON request is complete. Add it inside the callback function.

var recipient = 0;

$("#submit-button").click(function () {
    $.getJSON("/fetch.php?o=4&user=" + k, function (B) {
        $.each(B, function (index, result) {
            recipient = 1;
        });

        if (recipient == 1) {
            alert("yes");
        }
    });
});

answered Jul 3, 2013 at 18:15

Austin Brunkhorst

21.1k6 gold badges49 silver badges61 bronze badges

1 Comment

user892134 Over a year ago

is there a way to make sure JSON request is complete, so i don't have to have it in the callback function?

Collectives™ on Stack Overflow

jquery change variable function not working

2 Answers 2

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related