Proper way to re-user mongodb connection in node.js

Question

I tried searching on the web and found no obvious code samples of how reuse the mongodb.connection object. This is what I have currently and would anyone please verify if this is okay.

var app = express();
var mongodb = require('mongodb').MongoClient, format = require('util').format;
var db = null;

app.get('/api/v1/put/:var1/:var2', function(req, res){
  collection = db.collection('collection');
  /** .. logic ... **/
});

mongodb.connect('mongodb://127.0.0.1:27017/mydb', function(err, mdb){
    db = mdb;
    app.listen(8000);
});

moka · Accepted Answer · 2013-07-04 09:10:29Z

1

Your approach will have problem that once application runs it will register express route. If there is idling connections to your web server, then they will be processed ASAP, that will lead to db is undefined.

In order to prevent this, I would recommend to register express routing only after database is connected.
As well you can cache collections instead of getting them on each request.

answered Jul 4, 2013 at 9:10

moka

23.1k4 gold badges53 silver badges67 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

James Lin Over a year ago

Do you mean by putting app.get inside mongodb.connect ?

moka Over a year ago

Exactly. Put route definition inside of database connect callback. In fact you could even tidy it up, and have global event that you can reuse all around that will be triggered on connect to db.

James Lin · Accepted Answer · 2013-07-09 05:48:56Z

1

this is just to refactor my question's code to reflect Maksims' suggestion

var app = express();
var mongodb = require('mongodb').MongoClient, format = require('util').format;

mongodb.connect('mongodb://127.0.0.1:27017/mydb', function(err, db){
    collection = db.collection('collection');

    app.get('/api/v1/put/:var1/:var2', function(req, res){
      /** .. logic ... **/
    });

    app.listen(8000);
});

answered Jul 9, 2013 at 5:48

James Lin

26.8k39 gold badges144 silver badges251 bronze badges

Collectives™ on Stack Overflow

Proper way to re-user mongodb connection in node.js

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related