OutOfMemory when uploading files

Question

My code:

int chunk = Request["chunk"] != null ? int.Parse(Request["chunk"]) : 0;
string fileName = Request["name"] != null ? Request["name"] : string.Empty;
Response.Write(Request.Files.Count);
HttpPostedFile fileUpload = Request.Files[0];

var uploadPath = Server.MapPath("~/uploaded-files");
if (Request.QueryString["originals"] == "yes")
{
    using (var fs = new FileStream(Path.Combine(uploadPath, fileName), chunk == 0 ? FileMode.Create : FileMode.Append))
    {
        var buffer = new byte[fileUpload.InputStream.Length];
        fileUpload.InputStream.Read(buffer, 0, buffer.Length);
        fs.Write(buffer, 0, buffer.Length);
    }
}

I get an 'System.OutOfMemoryException' error.

My machine has 4 gigs of RAM. The file in question is approximately 1 GB. I am using plUpload to do the upload.

I've Enabled the 3GB switch. No difference. I have lots of RAM available, why am I running out of memory? Is there an alternative approach that uses less memory?

Have you messed with your httpRuntime settings in config? HttpPostedFile should buffer to disk when over 256KB, unless you've upped requestLengthDiskThreshold. — Matt Self
– Matt Self, Commented Jul 5, 2013 at 18:12

Matt Self · Accepted Answer · 2013-07-05 18:22:27Z

4

An alternative implementation would be to use SaveAs on HttpPostedFile:

fileUpload.SaveAs(Path.Combine(uploadPath, fileName));

answered Jul 5, 2013 at 18:22

Matt Self

20.2k2 gold badges36 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Evan Parsons Over a year ago

Excellent! This does the trick, I'm still going to look into chunk uploading, but for now this works!

Collectives™ on Stack Overflow

OutOfMemory when uploading files

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related