How To Update table through if condition during while Loop

Question

 $cteachers = mysql_query("SELECT * FROM teachers WHERE teachers.stats = '1'") or die(mysql_error());
while($info = mysql_fetch_array( $cteachers ))
{

Print "<li><strong>$info['id'];</strong></li><li><strong>$info['name'];</strong></li>"<li><strong>$info['rnk'];</strong></li>;

$id = $info['id'];
$cnme = $info['name'];
$fnme = $info['f_name'];
$lnme = $info['l_name'];
$rnkk = $info['rnk'];

  $fullname = $fnme." ".$lnme;


if ($cnme == '')
{
$que2 = "UPDATE teachers (name) VALUES('$fullname') WHERE teachers.f_name = '"$fnme"' AND teachers.l_name = '"$lnme"'" or die(mysql_error());
$exe2 = mysql_query($que2) or die(mysql_error());

}

hello i am facing a problem please help me it will be provide full list of teacher's but if teacher full name field is empty then update it

@Prix is right. You do something like UPDATE ... SET ...=... — Sterling Archer
– Sterling Archer, Commented Jul 5, 2013 at 23:49
and do update before printing :) Otherwise it'll print empty first and then update. But I suggest to execute the query of Kickstart's answer first and then executing this query you stated — Fallen
– Fallen, Commented Jul 5, 2013 at 23:50

Kickstart · Accepted Answer · 2013-07-05 23:48:33Z

3

Why not do it in a single piece of SQL?

UPDATE teachers
SET name = CONCAT(f_name, " ", l_name)
WHERE stats = "1"
AND name = ""

(change name = "" to name IS NULL if it is a nullable field)

answered Jul 5, 2013 at 23:48

Kickstart

21.5k2 gold badges26 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Emilio Gort · Accepted Answer · 2013-07-05 23:52:50Z

0

You should use mysqli instead mysql or PDO Class to take advantage of prepared statement

if(empty($fnme) && empty($lnme)){
    $que2 = "UPDATE teachers set name='$fullname' WHERE id='$id'";
    $exe2 = mysqli_query($link,$que2);//$link is the conncetion parameter
}

answered Jul 5, 2013 at 23:52

Emilio Gort

3,4553 gold badges32 silver badges44 bronze badges

Comments

Mayank K. Swami · Accepted Answer · 2013-07-06 07:04:07Z

0

What the primary key of your table ? As I know we can update table base on the primary key

or

if (!isset($cnme)){
  $que2 = "UPDATE teachers set name='$fullname' WHERE teachers.f_name = '"$fnme"' AND teachers.l_name = '"$lnme"'";
  $exe2 = mysql_query($que2) or die(mysql_error());

}

edited Jul 6, 2013 at 7:04

Mayank K. Swami

57.3k23 gold badges130 silver badges148 bronze badges

answered Jul 5, 2013 at 23:50

Angripa

1572 gold badges4 silver badges14 bronze badges

Collectives™ on Stack Overflow

How To Update table through if condition during while Loop

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related