PHP MySQL query variables not returning

Question

I store my testimonials in a database table and would like them to be displayed on my website via this for loop:

<?php

$count = mysql_fetch_assoc(mysql_query("SELECT COUNT(*) cnt FROM testimonials"));

for ($i = 1; $i <= intval($count['cnt']); $i++)
{
    $sql = mysql_query("SELECT * FROM testimonials WHERE id='{$i}'");
    ?>
    <li class="span4">
        <div class="thumbnail thumbnail-1">
            <section> 
                <a class="link-1" style="cursor:pointer;"><?php echo $sql['name'] ?></a>
                <p><?php echo $sql['text'] ?></p>
                <a href="http:// <?php echo $sql['product'] ?> /" class="link-1"><?php echo $sql['product'] ?></a>
            </section>
        </div>
    </li>

    <?php
}

?>

The issue is that the $sql variables product, name and text are not displaying. However the $count is getting the correct intval, so it knows there are entries.

It's also worth pointing out that the loop is working as I get the <li> <div> and <section> tags working, the only issue is the <a>'s and the <p> not getting the textual value from the echo

P.S. I know that mysql_* functions are depreciated however my php version 5.3 and they are only depreciated from 5.5 so they are ok for my website.

You already got answer, but... i would really solve this on another way. You can have too many queries in loop, and it could seriously affect performance... — sinisake
– sinisake, Commented Jul 6, 2013 at 10:48

echo_Me · Accepted Answer · 2013-07-06 10:46:33Z

2

you missed to fetch second sql

add this line

   $result= mysql_fetch_assoc($sql) ;

and then call your variables like that

 <?php echo $result['name'] ; ?>
 <?php echo $result['product'] ;?>
 <?php echo $result['product'] ; ?>
                              ^^-----dont forget `;` because you missed them also

edited Jul 6, 2013 at 10:46

answered Jul 6, 2013 at 10:41

echo_Me

37.2k5 gold badges62 silver badges81 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

RedJax Over a year ago

I've tried this before and it gave me an error on the page. I will try again and post what is displayed on the page

RedJax Over a year ago

Nevermind, it worked thanks a lot. When I get the change I will accept the answer.

RedJax Over a year ago

I said about mysql_* in the question, please read all of it before saying about it.

RedJax Over a year ago

Oh btw, when you do <?php ?> for 1 line, the ; is automatically added and it not needed

Collectives™ on Stack Overflow

PHP MySQL query variables not returning

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related