delete query not working in c#

Question

i use sql server in my database

and here is the code

private void btnDelete_Click(object sender, EventArgs e)
        {
            try
            {
                    //GlobalClass.dt.Rows[rowId].Delete();
                    //GlobalClass.adap.Update(GlobalClcass.dt);

                cDatabaseSQLServer.Delete("satuan", "WHERE id = " + rowId + "");
                    //this.Close();  
            }
            catch (Exception ex)
            {
                MessageBox.Show(ex.ToString());
            }
        }

public bool Delete(String tableName, String where)
        {
            switch (sqlType)
            {
                case DATABASE_SQL_TYPE.DATABASE_SQL_TYPE_SQLITE:
                    return cSQLite.Delete(tableName, where);
                case DATABASE_SQL_TYPE.DATABASE_SQL_TYPE_MSSQL:
                    return cSQL.Delete(tableName, where);
            }
            return false;
        }

public bool Delete(String tableName, String where)
        {
            Boolean returnCode = true;
            try
            {
                this.ExecuteNonQuery(String.Format("delete from {0} where {1};", tableName, where));
            }
            catch (Exception fail)
            {
                MessageBox.Show(fail.Message);
                returnCode = false;
            }
            return returnCode;
        }

when i debug the application , the delete is not working and the data still exist in datagridview, how to fix that?

Looks like you would end up with two WHERE in a row. Also use parameterised queries. — Martin Smith
– Martin Smith, Commented Jul 8, 2013 at 9:03
You've got quite a big security hole in the Delete function. What if I pass ; drop all as my where argument? — Jeff Foster
– Jeff Foster, Commented Jul 8, 2013 at 9:03
cDatabaseSQLServer.Delete("satuan", "WHERE id = " + rowId + ""); seems that WHERE keyword is getting sent in query 2 times.... remove the WHERE keyword — Nitin S
– Nitin S, Commented Jul 8, 2013 at 9:04
@all . i forgot to remove WHERE in my query. in delete method. @Jeff Foster . i try to pass drop all in my Where argument but not working. — Puja Surya
– Puja Surya, Commented Jul 8, 2013 at 9:19

gzaxx · Accepted Answer · 2013-07-08 09:05:19Z

2

Your query is wrong, you have 2 times where, either change your method call or query creator:

cDatabaseSQLServer.Delete("satuan", "id = " + rowId + ""); //remove where from here

as it is here:

this.ExecuteNonQuery(String.Format("delete from {0} where {1};", tableName, where));

answered Jul 8, 2013 at 9:05

gzaxx

17.6k2 gold badges40 silver badges55 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

delete query not working in c#

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related