concatenating strings in .each loop

Question

This may be a dumb question but I can't seem to get it or find it anywhere.

I have a .each function that returns the id's of a bunch of divs on a page and then assigns them a number. I need them to be outputted in a specific format all as one string so I can pass them to a database and use them as "sort_order" values. (I split them through a sproc in my database).

Here is my code:

jQuery('#updateAllContentButton').click(function() {
    var count = 1;
 jQuery('.CommentaryItem').each(function() {
    var id = GetID(jQuery(this));
        var data_str = (id + ':' + count + '~');
        console.log(data_str);
        count++;
    });
});

So that returns each data_str on a separate line but I need it to return it like this: 144:2~145:3~146:4~147:4~148:5 (so on)

Any help would be appreciated, thanks!

Denys Séguret · Accepted Answer · 2013-07-12 12:58:48Z

11

Use map and join :

jQuery('#updateAllContentButton').click(function() {
    console.log(jQuery('.CommentaryItem').map(function(i) {
        return GetID(jQuery(this)) + ':' + (i+1);
    }).get().join('~'));
});

Note that you don't have to count yourself : Most jQuery iteration functions do it for you.

edited Jul 12, 2013 at 12:58

answered Jul 9, 2013 at 13:47

Denys Séguret

384k90 gold badges813 silver badges780 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Zibellino Over a year ago

This syntax can also be called inside a string concatenation (+).

mohkhan · Accepted Answer · 2013-07-09 13:47:49Z

0

You can use an array for that. Like this...

jQuery('#updateAllContentButton').click(function() {
    var count = 1;
    var arr = [];
 jQuery('.CommentaryItem').each(function() {
    var id = GetID(jQuery(this));
    var data_str = (id + ':' + count + '~');
    arr.push(data_str);
    //console.log(data_str);
    count++;
 });
 console.log(arr.join());
});

answered Jul 9, 2013 at 13:47

mohkhan

12.3k2 gold badges27 silver badges27 bronze badges

Comments

Gintas K · Accepted Answer · 2013-07-09 13:57:02Z

0

try this:

jQuery('#updateAllContentButton').click(function() {
var count = 1;
var data_str = "";
jQuery('.CommentaryItem').each(function() {
var id = GetID(jQuery(this));
    data_str += (id + ':' + count + '~');
    console.log(data_str);
    count++;
});

});

edited Jul 9, 2013 at 13:57

answered Jul 9, 2013 at 13:48

Gintas K

1,4783 gold badges18 silver badges39 bronze badges

3 Comments

Gintas K Over a year ago

I mean use += on data_str instead of just = :)

J215D Over a year ago

After posting I did try this way but you have to declare data_str before the each loop and it ends up adding an extra ~ at the end.

Gintas K Over a year ago

Yeah, I've corrected that :) Still the best solution is posted by dystroy :)

Stephan Weinhold · Accepted Answer · 2016-06-01 11:37:22Z

0

change

var data_str = (id + ':' + count + '~');

to

data_str+ = (id + ':' + count + '~');

full code

jQuery('#updateAllContentButton').click(function() {
    var count = 1,
        data_str;

    jQuery('.CommentaryItem').each(function() {
        var id = GetID(jQuery(this));
        data_str += (id + ':' + count + '~');
        console.log(data_str);
        count++;
    });
});

edited Jun 1, 2016 at 11:37

Stephan Weinhold

1,6411 gold badge28 silver badges37 bronze badges

answered Jul 9, 2013 at 13:49

Ganesh Rengarajan

2,00613 silver badges26 bronze badges

Collectives™ on Stack Overflow

concatenating strings in .each loop

4 Answers 4

1 Comment

Comments

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related