execution of some code inside javascript function

Question

I have a div with some example code in it. I'd like to execute this code after pressing a button. Here's what I've tried:

HTML

<button onclick="javascript:playcode()"> </button>

JS

function playcode () {
     var execcode= "";
     for (i=1; i<=countCodeLine (); i++)
         execcode += document.getElementById("line"+i).innerText;

     var div= document.getElementById ("mydiv");
     var scr= document.createElement ('script', "");
     div.innerHTML= "play() {"+execcode+"}";
     div.appendChild(scr);
     play();
}

but it doesn't work. How can i do this?

UPDATE: here the errors from the console:

(line 9: pre.appendChild(scr)) Uncaught SyntaxError: Unexpected token { 
(line 10: play()) Uncaught TypeError: object is not a function

what does not work? Do you get any errors? (You don't need the named jump label javascript: btw if you don't use break or things like that). — Thilo
– Thilo, Commented Jul 11, 2013 at 9:46
There's no reason this doesn't work, except if the onclick attribute was changed or the javascript not loaded. — edi9999
– edi9999, Commented Jul 11, 2013 at 9:47
it looks like you could just use an eval here to get the exact functionality. — Justin L.
– Justin L., Commented Jul 11, 2013 at 9:48

Justin L. · Accepted Answer · 2013-07-11 09:52:34Z

1

If you are indeed getting the right HTML into execcode, you can use

eval(execcode);

You can check this by just doing a simple console.log(execcode) or alert(execcode) to verify that it's loaded correctly.

However, I can guarantee you that this is almost certainly a very, very bad idea. it'd be trivial for someone to just edit your DOM and insert whatever malicious javascript they want.

answered Jul 11, 2013 at 9:52

Justin L.

13.7k5 gold badges51 silver badges86 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Justin L. Over a year ago

you're welcome, but remember that you probably shouldn't do this in a production environment.

Collectives™ on Stack Overflow

execution of some code inside javascript function

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related