Regex Replace doesn't obey $1

Question

var input = document.getElementById('textinput').value;
var lines = input.split('\n');
var output = '';       
$.each(lines, function(key, line) {

    for(var iii=0; iii<=key; iii++) //for each line
    {
        var filenameRegex = /^\* \[\[Media:(.+?)(\|)/;
        var results = lines[iii].match(filenameRegex);
        var filename;
        console.log('lines[iii]= '+lines[iii]);
            if(results!==null && results.length!== 0)
            {
                  output += lines[iii].replace(filenameRegex,'$1'); 
            }
    }

I try hard but the output is always output += lines[iii].replace(filenameRegex,'$1$2') even though I only want $1

Example input: * [[Media:importantstuff|unimportantstuff]]

Expected output: importantstuff

Actual output: importantstuffunimportantstuff]]

Also, there is no need to do for loop, since you already have $.each(lines.... — mishik
– mishik, Commented Jul 12, 2013 at 9:28
Not the problem, but just in case: using /^* [[Media:(.+?)(\|)/ in replace will only replace the first occurence, add a "g" letter at the end of the regex ot make it global. — Ricola3D
– Ricola3D, Commented Jul 12, 2013 at 9:29
full code here codepen.io/raindrop11/pen/riBIw tell me if you can't access it — hexicle
– hexicle, Commented Jul 12, 2013 at 9:29
Why don't you just remove the 2nd pair of parenthesis if you don't want any $2 captured ? — Ricola3D
– Ricola3D, Commented Jul 12, 2013 at 9:32
The input is * [[Media:importantstuff|unwantedstuff]] on each line — hexicle
– hexicle, Commented Jul 12, 2013 at 9:34

mishik · Accepted Answer · 2013-07-12 09:38:37Z

1

If I understood you correctly, you are looking for this:

Demo

Code:

var filenameRegex = /^\* \[\[Media:(.+?)\|.*/;
var results = lines[iii].match(filenameRegex);
var filename;
console.log('lines[' + iii + ']= ' + lines[iii]);
console.log('key[' + iii + ']= ' + key);
if (results !== null && results.length !== 0) {
    output += lines[iii].replace(filenameRegex, '$1');
}

answered Jul 12, 2013 at 9:38

mishik

10k9 gold badges48 silver badges69 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Regex Replace doesn't obey $1

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related