javascript objects, what could be wrong with this code?

Question

I am following a tutorial on Codecademy and it says

unexpected token {

What is the error here please?

This is what I need to do

Write an if statement that checks to see if suitcase has the shorts property.

If your if statement evaluates to true, print the value of the shorts property.

If your if statement evaluates to false, set the shorts property to any value you wish using dot notation. Then print the value of the shorts property.

var suitcase = {
    shirt: "Hawaiian"
};
if (suitcase.hasOwnProperty("shorts") {
        console.log(suitcase.shorts)
    } else if (suitcase.hasOwnProperty != ("shorts")) {
        suitcase = {
            shorts: "tailormade"
        };
        console.log(suitcase.shorts);
    }
}

i mean i know its saying unexpected { but i dont see an unexpected { — Rtr Rtr
– Rtr Rtr, Commented Jul 13, 2013 at 6:46
if(suitcase.hasOwnProperty("shorts"){. You have not closed the parenthesis. — Shobit
– Shobit, Commented Jul 13, 2013 at 6:46
Check this line if(suitcase.hasOwnProperty!=("shorts") you should remove != — omma2289
– omma2289, Commented Jul 13, 2013 at 6:47
@RtrRtr Use something like jslint.com to proof these as they provide a bit more verbatim detail on errors and allows you to debug as fast as you can type until valid. — cerd
– cerd, Commented Jul 13, 2013 at 6:58

Hanna · Accepted Answer · 2013-12-03 20:19:18Z

3

var suitcase = {
     shirt: "Hawaiian"
     };

     if(suitcase.hasOwnProperty("shorts")){

      console.log(suitcase.shorts);


     }else if(!suitcase.hasOwnProperty("shorts")){

     suitcase = { shorts: "tailormade"};
      console.log(suitcase.shorts);


    }

Things that changed:

 if(suitcase.hasOwnProperty("shorts"){

Was missing parenthesis

 if(suitcase.hasOwnProperty("shorts")){

And this:

}else if(suitcase.hasOwnProperty!=("shorts")){

Removed != and moved ! in front.

}else if(!suitcase.hasOwnProperty("shorts")){

Do note, that you could just say else, there's no need for an else if. I also removed the last closing bracket and added one semi-colon after the first console.log. And since you're doing console.log(suitcase.shorts); in both places, just move it out of the conditionals all together.

So we could further reduce this code to this:

var suitcase = {
     shirt: "Hawaiian"
     };
 if(!suitcase.hasOwnProperty("shorts")){
     suitcase = { shorts: "tailormade"};
    }
console.log(suitcase.shorts);

edited Dec 3, 2013 at 20:19

answered Jul 13, 2013 at 6:48

Hanna

10.9k11 gold badges60 silver badges91 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Frederik.L Over a year ago

+1, this is the only answer that fix both problems in this code

Rtr Rtr Over a year ago

Hi, thanks so much, how do i do this what is wrong with this code.

Rtr Rtr Over a year ago

var nyc = { fullName: "New York City", mayor: "Michael Bloomberg", population: 8000000, boroughs: 5 }; // write your for-in loop here for( var "population" in nyc){ console.log(population); }

mplungjan Over a year ago

I think he wants to ADD the shorts, not replace the shirt

Hanna Over a year ago

If you want to add something, say suitcase["shorts"] = "tailormade";

Niet the Dark Absol · Accepted Answer · 2013-07-13 06:48:35Z

1

Your if statement is missing a ) - whenever you get an "unexpected something" error, always count your parentheses. It helps to use an editor that supports bracket matching, such as Notepad++.

answered Jul 13, 2013 at 6:48

Niet the Dark Absol

326k86 gold badges480 silver badges604 bronze badges

Collectives™ on Stack Overflow

javascript objects, what could be wrong with this code?

2 Answers 2

5 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related