I have got this code below which should:
Select column odjezd
From table stanice
Order by odjezd
where akce=zakce.Text
SqlCommand combobox = new SqlCommand("SELECT odjezd FROM stanice
ORDER BY odjezd ASC
WHERE akce="+zakce.Text, spojeni);
It gives me this error: Incorrect syntax near WHERE.
Would someone please improve my code? Thanks in advance
You're ORDER BY clause must be last and you are missing the single quotes around your string in WHERE clause.
By the way you should use a parameter instead string manipulation for your command text, to prevent from SQL injection.
var command = new SqlCommand("SELECT odjezd FROM stanice WHERE akce=@akce ORDER BY odjezd ASC", spojeni);
command.Parameters.Add(new SqlParameter("@akce", zakce.Text));
ORDER BY has to go for last....
You
So it will become like:
var command new SqlCommand("SELECT odjezd FROM stanice WHERE akce="
+ zakce.Text + " ORDER BY odjezd ASC", spojeni)
please try this code:
SqlCommand combobox = new SqlCommand("SELECT odjezd FROM stanice WHERE akce='"+zakce.Text + "' ORDER BY odjezd ASC", spojeni);
I hope it would work for you.
ORDER BY
has to go last.
Where clause goes before order by
ORDER BY should go after WHERE, and I believe you'll need a single quote arount what you're searching for.
SqlCommand combobox = new SqlCommand("SELECT odjezd FROM stanice WHERE akce='"+zakce.Text + "' ORDER BY odjezd ASC", spojeni);
Your statement is not ordered correctly, a handy run down of SELECT statement ordering can be found here (amongst other places): http://msdn.microsoft.com/en-us/library/ms189499.aspx
So in your case, you would want to order your statement thusly:
SELECT odjezd
FROM stanice
WHERE ...
ORDER BY odjezd ASC
As Woni has pointed out, it would also be better if you utilised SqlCommand.Parameters, to enforce correct data types, and protect you against potential exploits.
