PHP Variable Variables don't work... Why?

Question

I'm using a function that returns a Fetched Array from a Database ( PDO::fetch(PDO::FETCH_ASSOC) ).

this function returns A LOT OF COLUMNS and when I am editing all those columns in a Form, obviously I need the fields to be populate with the current data.

Code (modified for the question):

//returns something like $owner["name"], $owner["lastname"], 
//$owner["phone1"] ... and 53 fields more.

$owner = controllerGetOnwer($ownerID);

//So I used a foreach to create VARIABLE VARIABLES
foreach($owner as $key=>$value) {
     ${$key} = $value; //you get something like $name = <what is in that column>
}

I am gonna use this form in a lot of pages, not only for owners, but also for customers, administrators, and so on... That's why I decided to put the form in a function inside a static class I already used to 'render' all the HTML I will use a lot of times (such as Headers, logos, menus, etc)

//This is inside the HTMLRenderClass

renderTheEditForm() {

?>
<form>
    Name: *<br/>
    <input type="text" name="personalname" value="<?php if(isset($name)) echo $name; ?>"/><br/><br/>
    Last Name: *<br/>
    <input type="text" name="personallastname" value="<?php if(isset($lastname)) echo $lastname; ?>"/><br/><br/>
    Phone Number 1:<br/>
    <input type="text" name="personalphone1" value="<?php if(isset($phone1)) echo $phone1; ?>"/><br/><br/>


<!-- AND 53 FIELDS MORE -->


</form>    
<?PHP
}

All the variables that you see inside the VALUE attribute are the same as the ones that are being created dinamically in the FOREACH. When I paste the form HTML code below the Foreach, I can see the data being loaded, but when I use the Function from the HTMLRenderClass I get nothing... I haven't been able to find the reason.

I hope I explained well, thanks beforehand!

Would [extract()](php.net/manual/en/function.extract.php) not work? — Chris Rockwell
– Chris Rockwell, Commented Jul 16, 2013 at 3:48
Why? Why create a level of indirection? Why not just use the original array values? — user1864610
– user1864610, Commented Jul 16, 2013 at 3:49
With 53 fields I'd just think of a different approach... How about storing all data in an array by name, value and label and generating the HTML with PHP in a loop? — elclanrs
– elclanrs, Commented Jul 16, 2013 at 3:50
your idea is wrong ,how are you assigning variables inside a function which are not defined ? — Arun Killu
– Arun Killu, Commented Jul 16, 2013 at 3:50
I agree with Arun. You must define those variables or pass them into the function — Chris78
– Chris78, Commented Jul 16, 2013 at 3:54

Chris78 · Accepted Answer · 2013-07-16 03:57:57Z

1

It appears that you need to define your variables inside the function or pass them into the function.

answered Jul 16, 2013 at 3:57

Chris78

3872 gold badges5 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Orangepill Over a year ago

as clrockwell stated in the comments using extract is a one line replacement for the foreach loop (god forbid if one of the keys in the array is "owner")

JuanBonnett Over a year ago

It worked... I declared the function that renders the FORM this way: ..static function renderTheForm($currentValues)

Orangepill Over a year ago

Try replacing foreach($currentvalues as $key=>$value) { ${$key} = $value; } with extract($currentvalues);

JuanBonnett Over a year ago

Using Extract() instead of a foreach loop works perfect... I just didn't know that Function.. Thank you!

Collectives™ on Stack Overflow

PHP Variable Variables don't work... Why?

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related