ASP.NET MVC - Simple If Else

Question

For some reason I can't seem to get my head around why I get a The if block is missing a closing "}" character. Make sure you have a matching "}" character for all the "{" characters within this block, and that none of the "}" characters are being interpreted as markup. error in my ASP.NET MVC Application.

@foreach (var image in Model.Images)
{
    if (counter == Model.Images.Count - 1)
    {
        <div style="float: left; height: 250px; padding-right: 5px;">
    }
    else
    {
        <div style="float: left; height: 200px; padding-right: 5px;">
    }
    ....
    ....

Prior to the above, I was simply doing: <div style="float: left; height: 200px; padding-right: 5px;">, however I am in need of this If Else to make it look better.

What am I doing wrong in the If Else statement?

u must use @ first time. so dont use @ again before else

CocLn
– CocLn

2013-07-16 10:34:35 +00:00
Commented Jul 16, 2013 at 10:34 — CocLn
– CocLn, Commented Jul 16, 2013 at 10:34
I tried that before too but it doesn't work.

Subby
– Subby

2013-07-16 10:39:16 +00:00
Commented Jul 16, 2013 at 10:39 — Subby
– Subby, Commented Jul 16, 2013 at 10:39

Adrian Wragg · Accepted Answer · 2013-07-16 10:51:48Z

2

Your problem is that the MVC parser is interpreting your code as you having left an open <div> sitting around. Rather than opening two, try reworking your code and outputting just one:

@foreach (var image in Model.Images)
{

    int height;

    if (counter == Model.Images.Count - 1)
    {
        height = 250;
    }
    else
    {
        height = 200;
    }

    <div style="float: left; height: @(height.ToString()+"px"); padding-right: 5px;">
        ...
        ...
    </div>
}

It could also be done in an even more compact manner:

@foreach (var image in Model.Images)
{

    bool condition = (counter == Model.Images.Count - 1)

    <div style="float: left; height: @( condition ? "200px" : "250px"); padding-right: 5px;">
        ...
        ...
    </div>
}

answered Jul 16, 2013 at 10:51

Adrian Wragg

7,4193 gold badges30 silver badges52 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Oliver Over a year ago

I think this is right. I spent 30 minutes scratching my head over the same issue. html tags must be closed within braces. It is annoying that the error message is not very descriptive.

Erik Schierboom · Accepted Answer · 2013-07-16 10:40:55Z

1

This should work:

@foreach (var image in Model.Images)
{
    if (counter == Model.Images.Count - 1)
    {
        <text><div style="float: left; height: 250px; padding-right: 5px;"></text>
    }
    else
    {
        <text><div style="float: left; height: 200px; padding-right: 5px;"></text>
    }
}

answered Jul 16, 2013 at 10:40

Erik Schierboom

16.7k10 gold badges67 silver badges82 bronze badges

1 Comment

Erik Schierboom Over a year ago

I have updated my answer, could you check to see if it works now?

gregjer · Accepted Answer · 2013-07-16 10:51:46Z

1

I would try to replace if/else completely like that:

 <div style="@(counter == Model.Images.Count - 1 ? "float: left; height: 250px; padding-right: 5px;" : "float: left; height: 200px; padding-right: 5px;")">

answered Jul 16, 2013 at 10:51

gregjer

2,8432 gold badges20 silver badges18 bronze badges

1 Comment

Subby Over a year ago

I used this approach and extracted the style and placed it in a .css files.

Nick · Accepted Answer · 2013-07-16 10:42:58Z

0

Try wrapping the whole thing in @{ ... }. And remove the @ symbols from the existing syntax.

answered Jul 16, 2013 at 10:42

Nick

2,3552 gold badges14 silver badges26 bronze badges

Comments

Cosmin · Accepted Answer · 2013-07-16 12:15:05Z

0

Check if @ from foreach is needed and also try to append @: in front of every div

answered Jul 16, 2013 at 12:15

Cosmin

2,2141 gold badge23 silver badges39 bronze badges

Collectives™ on Stack Overflow

ASP.NET MVC - Simple If Else

5 Answers 5

1 Comment

1 Comment

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

1 Comment

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related