Hierarchal Menu in PHP from Array

Question

Alright, it's hump day, and my brain's already shot.

Can someone tell me what I'm doing wrong here, I'm trying to build a Navigation list properly (hierarchal)

Here's the array:

Array
(
[0] => Array
    (
        [contentID] => 1
        [parentID] => 0
        [LinkAlias] => 
    )

[1] => Array
    (
        [contentID] => 2
        [parentID] => 0
        [LinkAlias] => inner
    )

[2] => Array
    (
        [contentID] => 3
        [parentID] => 2
        [LinkAlias] => inner-2
    )

[3] => Array
    (
        [contentID] => 4
        [parentID] => 3
        [LinkAlias] => inner-21
    )

)

And my attempts at the recursive function:

    // Parse out the array for displaying a multi-level menu
    private function ParseMenu($menu, $parent = 0){
        $ret .= '<ul>';
        $iCt = count($menu);


        for($i=0; $i < $iCt; ++$i){
            if($menu[$i]['parentID'] == $parent){               
                $ret .= '   <li>' . $menu[$i]['LinkAlias'];
                if($parent > 0){
                    $ret .= ParseMenu($menu, $menu[$i]['contentID']);
                }
                $ret .= '</li>';                
            }
        }
        $ret .= '</ul>';
        return $ret;
    }

Right now, all it is returning:

<ul>
    <li></li>
    <li>inner</li>
</ul>

It should be showing

<ul>
    <li></li><!-- yes this is intentional -->
    <li>inner
            <ul>
                    <li>inner-2
                            <ul>
                                    <li>inner-21</li>
                            </ul>
                    </li>
            </ul>
</ul>

So.. what am I doing wrong, and how can I fix it?

Chris Morrissey · Accepted Answer · 2013-07-17 14:33:50Z

3

Make this line ...

if($parent > 0){
    $ret .= ParseMenu($menu, $menu[$i]['contentID']);
}

into ...

$ret .= $this->ParseMenu($menu, $menu[$i]['contentID']);

You are never calling your function again because you are always starting with $parent = 0

$ret .= '</ul>';
if($ret == '<ul></ul>'){ 
    return;
} else {
    return $ret;
}

edited Jul 17, 2013 at 14:33

answered Jul 17, 2013 at 13:43

Chris Morrissey

4892 silver badges4 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Kevin Over a year ago

what a tool I am... told you... brain is shot. It works, this is inside a function, so I have to $this->ParseMenu it... Few more tests and I'll accept. Thanks~

Chris Morrissey Over a year ago

i have updated my code, you are working in a class so you will need $this->

Kevin Over a year ago

:) yeah. Works good. Now the only thing left is to get rid of the extra <ul></ul> when there are no children

Collectives™ on Stack Overflow

Hierarchal Menu in PHP from Array

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related