Java: Else after multiple ifs or comparing two strings

Question

Sorry if the title doesn't make sense. Basically, I'm a noob, and for learning purposes I'm trying to create a basic program which asks first for gender then for age to determine access. The program is sexist for testing purposes. Anyway, heres what I have:

    System.out.println("What is your Gender?");
    String gender = input.nextLine();
        if (gender.equals ("male")){
            System.out.println("What is your age?");
            int agem = input.nextInt();
            if (agem >= 21 && agem < 65){
                System.out.println("Access Granted");
            }else{
                System.out.println("Access Denied");
            }
        }
        if (gender.equals ("female")){
            System.out.println("What is your age?");
            int agef = input.nextInt();
            if (agef >=18 && agef < 60){
                System.out.println("Access Granted");
            }else{
                System.out.println("Access Denied");
            }
        }

Now what I am trying to do is create a response in case the user enters something other than "male" or "female". I've tried using else in the case that both if statements are false but it hasn't worked.

I also tried creating another if statement like this one:

if (!gender.equals ("male") || ("female"));

But that doesn't work either.

Thanks

Ankit · Accepted Answer · 2013-07-18 22:10:23Z

2

as an immediate solution, you need to add following condition in the end

if (!(gender.equals ("male") || gender.equals("female"))); or

if (!gender.equals ("male") && !gender.equals("female"));

but to avoid unnecessary condition check the whole condition should look like this:

        if (gender.equals ("male")){
            //
        }
        else if (gender.equals ("female")){
            //
        } else {

        }

and since java 7, you can also use string bases switch statement:

switch(value){
    case "male":
        //todo
        break;
    case "female"
        //todo
        break;
    default:
        //todo
}

edited Jul 18, 2013 at 22:10

answered Jul 18, 2013 at 21:58

Ankit

6,6226 gold badges51 silver badges72 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

wlyles Over a year ago

Your first statement should be if (!gender.equals ("male") && !gender.equals("female")). Otherwise, it will always evaluate to true

user2506840 Over a year ago

if (!(gender.equalsIgnoresCase("male") && gender.equalsIgnoresCase("female"))) will be even better to guard against input like "Male" i feel.

bzzzrd · Accepted Answer · 2013-07-18 22:00:40Z

1

You can also go with a switch:

switch(gender) {
  case "male": 

    break;

  case "female":

    break;

  default: //everything else
}

Edit: string switch works since java 7

answered Jul 18, 2013 at 22:00

bzzzrd

3812 silver badges3 bronze badges

Comments

Thousand · Accepted Answer · 2013-07-18 22:25:39Z

1

this will work:

if (gender.equals ("male") || gender.equals("female"))
{ 
   //input is okay, do something
} 
else 
{ 
  //input is not "male" or "female"  
}

edited Jul 18, 2013 at 22:25

answered Jul 18, 2013 at 21:57

Thousand

6,6484 gold badges41 silver badges46 bronze badges

1 Comment

Jon Newmuis Over a year ago

@wyles, Those are not equivalent. Gender cannot both equal "male" and "female," so that would always be false. Then you are negating it, always returning true. Thus the block would always be executed.

Jon Newmuis · Accepted Answer · 2013-07-18 22:01:27Z

You may want to restructure your program to use if, else if, else.

For example:

System.out.println("What is your Gender?");
String gender = input.nextLine();
if (gender.equals ("male")){
    System.out.println("What is your age?");
    int agem = input.nextInt();
    if (agem >= 21 && agem < 65){
        System.out.println("Access Granted");
    }else{
        System.out.println("Access Denied");
    }
} else if (gender.equals ("female")){
    System.out.println("What is your age?");
    int agef = input.nextInt();
    if (agef >=18 && agef < 60){
        System.out.println("Access Granted");
    }else{
        System.out.println("Access Denied");
    }
} else {
    System.out.println("Unrecognized input.");
}

This is a little more succinct, as it's not possible for it to execute the female branch if the male branch has been executed, and it's not possible for it to execute the unrecognized branch if either the male or female branch has been executed.

P4T4R · Accepted Answer · 2013-07-18 22:35:12Z

0

The quickest solution to this would be to use:

if (gender.equals("Male")) {

} else if (gender.equals("Female")) {

} else {

}

edited Jul 18, 2013 at 22:35

answered Jul 18, 2013 at 22:08

P4T4R

1016 bronze badges

Collectives™ on Stack Overflow

Java: Else after multiple ifs or comparing two strings

5 Answers 5

2 Comments

Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

2 Comments

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related