Using RegEx to Split the Url

Question

I want to Split the url into two part using RegEx. I have saved the xml response into datatable and iterate through the each row using foreach. When I use the datatable value for regEx only 0 will be available. When I use the array index 1 it give the following Exception.

System.IndexOutOfRangeException: Index was outside the bounds of the array.

The Following is gives and Exception.

foreach (DataRow row in ndt.Rows)
{
    string imgurl =row["image1"].ToString();

    String[] fimgurl = Regex.Split(imgurl, @"small/");
    String  simgurl = fimgurl[1];
}

The Following It's working without any issue.

foreach (DataRow row in ndt.Rows)
{
    //TextBox1.Text = row["ImagePath"].ToString();
    string imgurl ="http://www.hotelbeds.com/giata/small/12/124356/124356a_hb_w_001.jpg";
    String[] fimgurl = Regex.Split(imgurl, @"small/");
    String  simgurl = fimgurl[1];
}

I Have saved the same url as string in My Datatable. I couldn't find what's wrong with that. Can anyone please help me on this?

Well imgurl obviously doesn't equal http://www.hotelbeds.com/giata/small/12/124356/124356a_hb_w_001.jpg?? — Liam
– Liam, Commented Jul 19, 2013 at 8:44

dav_i · Accepted Answer · 2013-07-19 10:15:12Z

5

Some people, when confronted with a problem, think "I know, I'll use regular expressions." Now they have two problems. --Jamie Zawinski

var uri = new Uri("http://www.hotelbeds.com/giata/small/12/124356/124356a_hb_w_001.jpg");

var firstPart = uri.Host + String.Concat(uri.Segments.Take(3));
  // returns: "www.hotelbeds.com/giata/small/"

var lastPart = String.Concat(uri.Segments.Skip(3));
  // returns: "12/124356/124356a_hb_w_001.jpg"

If you need the http, you can use uri.Scheme. Obviously just change 3 to some other number if you want to split in a different place.

Additionally you can search uri.Segments for the index of which directory you want if it changes.

edited Jul 19, 2013 at 10:15

answered Jul 19, 2013 at 8:36

dav_i

28.2k17 gold badges110 silver badges138 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Aziz Zaynutdinov · Accepted Answer · 2013-07-19 08:36:21Z

1

It can means only that

string imgurl =row["image1"].ToString();

not equals value, that you provides. Try to debug your code and find out what exactly value has your variable imgurl

answered Jul 19, 2013 at 8:36

Aziz Zaynutdinov

111 bronze badge

Comments

Swift · Accepted Answer · 2013-07-19 08:39:11Z

0

I don't think there is anything wrong with your code.

The problem is that you have an url that don't contain "small/" in it. so the Split function return an array of length 1, so when you try to access the index 1 you have exception.

If you want more detail you have to post the content of ndt.

a simple way to debuf is to print the url to the console so you can see the url:

foreach (DataRow row in ndt.Rows)
            {
    string imgurl =row["image1"].ToString();
    Console.WriteLine(imgurl)
    String[] fimgurl = Regex.Split(imgurl, @"small/");
    String  simgurl = fimgurl[1];
}

answered Jul 19, 2013 at 8:39

Swift

1,88114 silver badges17 bronze badges

3 Comments

Liam Over a year ago

there is no console in ASP.Net

Anirudha Over a year ago

use System.Diagnostics.Debug.WriteLine instead

Liam Over a year ago

That also won't work in Asp.Net. This is HTTP, your thinking like a windows app. The only place you can write to is the HTTP response.

Damith · Accepted Answer · 2013-07-19 08:45:39Z

0

in your grid there may be images without small/ in the url so better to add condition like below

if(fimgurl.Length >1)
      String  simgurl = fimgurl[1];

answered Jul 19, 2013 at 8:45

Damith

63.2k13 gold badges106 silver badges154 bronze badges

Comments

ostapische · Accepted Answer · 2013-07-19 08:47:43Z

0

I think you have an error in column name:
in first variant you use image1 column, in second variant you use ImagePath (in comment), maybe you must use ImagePath column like:

string imgurl = row["ImagePath"].ToString();

answered Jul 19, 2013 at 8:47

ostapische

1,5922 gold badges12 silver badges27 bronze badges

Collectives™ on Stack Overflow

Using RegEx to Split the Url

5 Answers 5

Comments

Comments

3 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

3 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related