implode() array to insert record into mySql database

Question

I have a single row in a PHP array and I would like to insert that row into mySQL database by imploding the keys and values into a string and using those strings in my Insert statement as follows:

$fields = implode(",", array_keys($_POST));
$newdata = implode(",", $_POST);

$query = (
"INSERT INTO Food_entered ($fields)
VALUES ('$newdata')");

$result = mysqli_query($dbc, $query);

I am able to create the strings, and they appear to be in proper form ,however the row is not being inserted. Seems like a simple approach but not sure what I'm missing.

Hmmm....Column count doesn't match value count at row 1. Thought I checked that. Not sure why when I there are an equal number of keys and values. — user2232681
– user2232681, Commented Jul 19, 2013 at 23:52

Rizier123 · Accepted Answer · 2015-03-26 11:21:21Z

9

As @Barmar has pointed out, the problem is your quotes are on the outside of your variable.

I think this may be an easier to follow/cleaner way of fixing this however than the method Barmar posted:

$newdata = "'" . implode("','", $_POST) . "'";

edited Mar 26, 2015 at 11:21

Rizier123

59.8k17 gold badges106 silver badges167 bronze badges

answered Jul 19, 2013 at 23:58

Jordan

1,4338 silver badges14 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user2232681 Over a year ago

I see that. I just needed to remove the double quote before implode and your suggestion worked fine.

Barmar · Accepted Answer · 2013-07-19 23:45:58Z

6

You need to quote each value, not the entire list of values:

$fields = implode(",", array_keys($_POST));
$newdata = implode(",", array_map(function($x) use ($dbc) {
    return "'" . $dbc->real_escape_string($x) . "'";
}, $_POST));

$query = (
"INSERT INTO Food_entered ($fields)
VALUES ($newdata)");

$result = mysqli_query($dbc, $query);

answered Jul 19, 2013 at 23:45

Barmar

789k57 gold badges554 silver badges669 bronze badges

5 Comments

Robert Over a year ago

Hello Barmar , kindly, this looks making things pretty automatic. Does this work if the rows are many? Or some cycle is needed?

Barmar Over a year ago

@Robert If you try to use multiple VALUES lists in a single insert, make sure you don't exceed max_allowed_packet.

Robert Over a year ago

Hi Barmar, thank you for the reply. Well, the rows will be not more than 20 or maximum 30. The poin is that I'm newbie. I have created one question here on stackoverflow stackoverflow.com/questions/45349503/… , can you kindly help me there? Thank you for any.

Robert Over a year ago

Or this solution applies exactly as in my question? If yes, just paste it there an I'll also provide to mark it as accepted (obviously) :-). Thank you for helping this noob ;-)

Robert Over a year ago

Ouch! Perfect, thank you for the duplicate question links.

Collectives™ on Stack Overflow

implode() array to insert record into mySql database

2 Answers 2

1 Comment

5 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

5 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related