Replace char sequence in a string not working

Question

I am retreiving data from a URL into a String a, and passing this string as an argument to gson's fromJson method. Now I need to replace some of the substrings in string a.

    String url = "abc";
    String a = getDataFromURL(url); //this string contains all the data from the URL, and getDataFromURL is the method that reads the data from the URL.
    String tmp = "\"reservation\":\"www.\"";
    String tmpWithHttp = "\"reservation\":\"http://www.\"";

    if(a.contains(tmp))
    {
    a = a.replace(a, tmpWithHttp);
    }

All the data in the URL is JSON. The requirement I have here is, if the String a contains a substring - "reservation":"www., replace that with "reservation":"http://www.

The above code I have is not working. Could someone please help me here?

In addition to Rohit Jain's answer, your code is checking for "reservation":"www.", not "reservation":"www. (as your question specifies). That small difference could cause it to not find the replacement string. — FThompson
– FThompson, Commented Jul 20, 2013 at 19:55
@Vulcan: Post it as an answer. I am pretty sure this is the real error here. — jlordo
– jlordo, Commented Jul 20, 2013 at 19:58
@Vulcan - You are 100% right. Yup, post it as an answer, and I will accept it :) — user2094397
– user2094397, Commented Jul 20, 2013 at 20:00

Rohit Jain · Accepted Answer · 2013-07-20 19:52:55Z

3

You probably mean:

a = a.replace(tmp, tmpWithHttp);

instead of:

a = a.replace(a, tmpWithHttp);

And you don't need to do a contains() check before replacing. String#replace method will replace only if the substring to replace is present. So, you can remove the surrounding if.

answered Jul 20, 2013 at 19:52

Rohit Jain

214k45 gold badges419 silver badges534 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user2094397 Over a year ago

Yup, sorry about that. I didn't paste my code as is. Modified it here in the question ;)

FThompson · Accepted Answer · 2013-07-20 20:03:55Z

2

In your question, you specify that you want to replace "reservation":"www.. However, in your code, you've added an extra escaped quote, causing the replacement to search for "reservation":"www.", which isn't present in the string.

Simply remove that last escaped quote:

String tmp = "\"reservation\":\"www.";

answered Jul 20, 2013 at 20:03

FThompson

28.8k13 gold badges63 silver badges95 bronze badges

Collectives™ on Stack Overflow

Replace char sequence in a string not working

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related