Getting Error When Insert in Ms Access 2007 Using c#

Question

I am trying to insert in database Ms Access 2007 . First i get all the file name from folder then copy that file name in database .Here is my Database screenshot.

This is my database screen shot

This is my code

       string some = "Nothing";
        Response.Write(v);
        string[] filePaths = Directory.GetFiles(Server.MapPath("~/Gallery/GalleryImage/" + v));
        int a =0;
        OleDbCommand cmd = new OleDbCommand();
        OleDbConnection mycon = new OleDbConnection();
        mycon.ConnectionString = @"Provider=Microsoft.ACE.OLEDB.12.0;Data Source=C:\Users\AGENTJ.AGENTJ-PC\Documents\Visual Studio 2010\WebSites\mfaridalam\App_Data\mfaridalam1.accdb";

        cmd = mycon.CreateCommand();
        mycon.Open();
        foreach (string item in filePaths)
        {
            a++;
            string filename = Path.GetFileName(item);
            string ips = 00 + a.ToString();



          cmd.CommandText = "INSERT INTO [Image] ([Image],[Sort],[Created],[Albumid],[Description],[title])VALUES(" + filename + "," + ips + "," + some + "," +
           v + "," + some + "," + some + ");";


          int temp = cmd.ExecuteNonQuery();
          if (temp > 0)
          {
              Response.Write("Writing is complete, Success!");

          }
          else
          {
              Response.Write("Application Error, Try Again!");
          }


          Response.Write(filename+ "<br/>");

                  }
        mycon.Close();
        cmd.Dispose();
        mycon.Dispose();

I am Getting this error

       No value given for one or more required parameters.

In line Line 42: int temp = cmd.ExecuteNonQuery();

As I can see you have 7 fields to insert and passing only 6 values. — Senad Meškin
– Senad Meškin, Commented Jul 22, 2013 at 19:30
No Its 6 Field and 6 values "INSERT INTO [Image] ([Image],[Sort],[Created],[Albumid],[Description],[title])VALUES(" + filename + "," + ips + "," + some + "," + v + "," + some + "," + some + ");"; I got solution Thank you anyway i was not using single quotes '' thanks anyway — Jay Zee
– Jay Zee, Commented Jul 22, 2013 at 19:36

Steve · Accepted Answer · 2013-07-22 19:47:33Z

3

If you had used a parameterized query this error would never be seen. The problem is in your string concatenation that lacks of quotes around the string passed for the values in every text/memo field present in your table.

A parameterized query could require more typing but is more readable and will avoid error in parsing values for strings, dates, decimals etc.... (and that big problem called Sql Injection )

cmd.CommandText = "INSERT INTO [Image] ([Image],[Sort],[Created],[Albumid]," + 
                  "[Description],[title])VALUES(?,?,?,?,?,?)";

cmd.Parameters.AddWithValue("@p1",filename);
cmd.Parameters.AddWithValue("@p2",ips);
cmd.Parameters.AddWithValue("@p3",some);
cmd.Parameters.AddWithValue("@p4",v);
cmd.Parameters.AddWithValue("@p5",some);
cmd.Parameters.AddWithValue("@p6",some);
int temp = cmd.ExecuteNonQuery();

edited Jul 22, 2013 at 19:47

answered Jul 22, 2013 at 19:37

Steve

217k22 gold badges242 silver badges296 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Jay Zee Over a year ago

Thank you i got it right query is this "INSERT INTO [Image] ([Image],[Sort],[Created],[Albumid],[Description],[title])VALUES('" + filename + "','" + ips + "','" + some + "','" + v + "','" + some + "','" + some + "');";

Steve Over a year ago

Yes it works until you have some value containing a single quote, then it crash with a syntax error. (For example Description="This is the best album from Guns N' Roses") And this is only a programming problem. You should also consider security concers like SQL Injection. No, really, do not use string concatenation, use always a parameterized query.

Jay Zee Over a year ago

Steve thanks your recommendation .. Can i contact you like on facebook or email so i can get some useful tips from you

Steve Over a year ago

Sorry @JayZee but I am very busy at the moment and I am sure that if you post other questions here you will get answers in no time. See you again on SO.

Collectives™ on Stack Overflow

Getting Error When Insert in Ms Access 2007 Using c#

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related