How to add multiple listeners in jQuery/javascript?

Question

for (key in this.mybutton)
       button = this.mybutton[key]

       $(button).click(function() {
            console.log("click:" + button)
       });

The result is always the name of the last button. How can I add multiple listeners in jQuery/javascript or erase the javascript reference button to a string in the for.

thanks in advance

Using 'this' or maybe you need a cosure there. Could you provide a working sample as jsfiddle which show what are you looking for? — A. Wolff
– A. Wolff, Commented Jul 23, 2013 at 10:20

adeneo · Accepted Answer · 2013-07-23 11:05:19Z

2

You need a ~~closure~~ new scope :

for (key in this.mybutton)
   (function(button) {
       $(button).click(function() {
            console.log("click:" + button)
       });
   })(this.mybutton[key]);
}

or just use this:

$(button).click(function() {
    console.log("click:" + this)
});

Concatenating a DOM element and a string in the console log doesn't seem like a very good idea ?

edited Jul 23, 2013 at 11:05

answered Jul 23, 2013 at 10:21

adeneo

319k29 gold badges410 silver badges392 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Felix Kling Over a year ago

No, not a closure (the event handler is already a closure). You need to create a new scope. See my comments here for a more extensive explanation (this is just regarding the first snippet, of course the second one is a much better solution anyway).

adeneo Over a year ago

@FelixKling - thanks, that's a good explanation, and even if I understood why it worked, I've never really thought about the fact that any function will create a closure, and as such the closure isn't the reason it works, passing the parameter to keep it constant within the new scope is!

Thomas Over a year ago

thanks,exactly what i want. The concatenation was just to give an simple example of my problem, it's doesn't have a real utility :p

Collectives™ on Stack Overflow

How to add multiple listeners in jQuery/javascript?

1 Answer 1

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related