Pass a PHP variable as a parameter in an inline javascript function call [duplicate]

Question

I'm building a shopping cart and have a simple but perplexing problem. I'm not good at javascript, so here it goes.

I'm trying to get the id of a record who's upc is equal to upc.

<input type="button" value="Add to Cart" onclick="get_product_id(<?=$row['upc']?>)" />

The reason I'm not getting the id directly is I'll be getting the record based on a list of options that builds the upc.

Uncaught ReferenceError: rtt is not defined 
onclick

However, if I pass any column of the records that is an int-type value, there is no error.

Quentin · Accepted Answer · 2013-07-24 14:19:33Z

2

String literals in JavaScript must be quoted. The value of $row['upc'] presumably doesn't include quote characters, so it is being treated as an identifier (a variable in that context).

answered Jul 24, 2013 at 14:19

Quentin

949k136 gold badges1.3k silver badges1.4k bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Ryan Lutz Over a year ago

Ah, gotcha. So either define the variable as a string earlier or put some more quotes on it right?

Quentin Over a year ago

You'll have to put quotes on it either way.

bestprogrammerintheworld · Accepted Answer · 2013-07-24 14:33:30Z

0

Try putting in apostrophes surrounding the upc-value:

<?php
$upc = $row['upc'];
?>
<input type="button" value="Add to Cart" onclick="get_product_id('<?=$upc;?>')" />

If you need to treat it as a number in javascript, then just use parseInt().

answered Jul 24, 2013 at 14:33

bestprogrammerintheworld

5,5299 gold badges48 silver badges76 bronze badges

Collectives™ on Stack Overflow

Pass a PHP variable as a parameter in an inline javascript function call [duplicate]

2 Answers 2

2 Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Linked

Related