Compile error while returning string arrays

Question

public String[] get_file_names_from_SD() /* Compiler complains here */ 
{
    String state = Environment.getExternalStorageState();
    if (state.equals(Environment.MEDIA_MOUNTED)) {
        File root = Environment.getExternalStorageDirectory();
        File dir = new File(root.getAbsolutePath() + "/journal_storage");
        if (dir.exists() & dir.isDirectory()) {
            return (dir.list());            
        }

    } else {
        Toast.makeText(getActivity(), "Media Mounted Issue", Toast.LENGTH_SHORT).show();
    }
}

So I am returning dir.list() which will contain an array of strings but for some reason compiler is showing an error "This method must return a result of type String[]".

According to the Android documentation, the method returns an array of Strings.

Can anyone can tell me what I am doing wrong?

instead of &, there should be && in condition.. :)

Chintan Rathod
– Chintan Rathod

2013-07-25 05:47:32 +00:00
Commented Jul 25, 2013 at 5:47 — Chintan Rathod
– Chintan Rathod, Commented Jul 25, 2013 at 5:47

sanbhat · Accepted Answer · 2013-07-25 05:44:42Z

2

All code paths of your method are NOT returning the String[]. You should return the String[] or null in the else block also since else block is a reachable code block of your method.

public String[] get_file_names_from_SD() /*Compiler complains here*/
    {
        String state = Environment.getExternalStorageState();
        if(state.equals(Environment.MEDIA_MOUNTED))
        {
            File root = Environment.getExternalStorageDirectory();
            File dir = new File(root.getAbsolutePath()+"/journal_storage");
            if(dir.exists() & dir.isDirectory())
            {
                return(dir.list());

            }

        }
        else
        {
        Toast.makeText(getActivity(), "Media Mounted Issue", Toast.LENGTH_SHORT).show();
        //--> return null;
        }
    }

answered Jul 25, 2013 at 5:44

sanbhat

17.6k6 gold badges52 silver badges65 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Juvanis · Accepted Answer · 2013-07-25 05:44:58Z

1

Puıt this line after your else statement:

return null;

This will guarantee that your method will return successfully. However, you should watch for NullPointerExceptions where you invoke this method.

answered Jul 25, 2013 at 5:44

Juvanis

26k5 gold badges74 silver badges88 bronze badges

Comments

saratbeesa · Accepted Answer · 2013-07-25 05:46:15Z

1

Not all the call paths lead to returning a String[], for e.g. if your SD card is not MOUNTED the control goes to the else block and doesn't return anything. You can simply end it with a return null; statement at the end of the block to make that error go away.

answered Jul 25, 2013 at 5:46

saratbeesa

4113 silver badges6 bronze badges

Comments

Shuhail Kadavath · Accepted Answer · 2013-07-25 05:47:17Z

1

Your else block is not returning anything .. Thats Y the error is thrown

else
    {
    Toast.makeText(getActivity(), "Media Mounted Issue", Toast.LENGTH_SHORT).show();
    // return something here .. If nothing , return null
    }

answered Jul 25, 2013 at 5:47

Shuhail Kadavath

4483 silver badges13 bronze badges

Collectives™ on Stack Overflow

Compile error while returning string arrays

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related