Arraylist sorting in c#

Question

I am trying to modify this code that already exists.The code was developed around 2008 and I am trying to fix the sort issue. I am also thinking of changing the code but wanted to fix the issue first.

ArrayList lineEmpNrs = new ArrayList();
taMibMsftEmpDetails employeeDetails; //taMibMsftEmpDetails is a custom class file

while (!HeaderFile.EndOfStream) //headerfile is employee information text file.
{
    headerRow = HeaderFile.ReadLine();
    headerFields = headerRow.Split(',');
    employeeDetails = BuildLine(headerFields[1],headerFields[2],headerFields[3]);
    lineEmpNrs.Add(employeeDetails);
}

 private taMibMsftEmpDetails BuildLine(string EmpId, string EmpName, String ExpnsDate)
 {
     taMibMsftEmpDetails empSlNr = new taMibMsftEmpDetails();
     empSlNr.EmployeeId  = EmpId;
     empSlNr.EmployeeName   = EmpName;
     empSlNr.ExpenseDate = ExpnsDate;
     return empSlNr;
 }

The Headerfile contains employee expense details. The empID is the key here and the headerFile can contain 'n' number of lines with same EmpID appearing in random order in the file.

I use lineEmpNrs to build some other information based on EmpID. So I want to have lineEmpNrs sorted based on EmpID. I tried the regular sort method but it didn't work.

Please suggest.

The site is currently on .NET 2.0 but the code is very old. I thought of changing the code but this was some fix that I wanted to do as is. But if other options are better then I will rewrite. — Anirudh
– Anirudh, Commented Jul 26, 2013 at 16:38
What is the exact type of HeaderFile? FileStream? StreamReader? — Joel Coehoorn
– Joel Coehoorn, Commented Jul 26, 2013 at 16:39

Sergey Berezovskiy · Accepted Answer · 2013-07-26 16:55:10Z

3

First - thus it is .Net 2.0 you can use strongly-typed generic list of type List<taMibMsftEmpDetails> instead of ArrayList:

List<taMibMsftEmpDetails> lineEmpNrs = new List<taMibMsftEmpDetails>();
// rest is same

Second - you can use method List<T>.Sort with Comparison<T> delegate to sort employees by id:

lineEmpNrs.Sort(delegate(taMibMsftEmpDetails e1, taMibMsftEmpDetails e2) { 
                   return e1.EmployeeId.CompareTo(e2.EmployeeId); 
                });

Instead of anonymous method you can create usual named method for comparing employees:

lineEmpNrs.Sort(CompareEmployees);

Also consider to improve naming in your code. Consider to use employees collection instead of lineEmpNrs, EmployeeDetails class instead of taMibMsftEmpDetails.

edited Jul 26, 2013 at 16:55

answered Jul 26, 2013 at 16:49

Sergey Berezovskiy

237k44 gold badges441 silver badges468 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Anirudh Over a year ago

@lazyberezovsky-> I have tried your option and testing it now. Once I make lineEmpNrs as List, will I have option to find out how many times the same EmpID exists in the list. Basically I am looking to find out empA record count is 99 and empB record count is 50 and so on. I had used this with Arraylist but now I have to modify it as lineEmpNrs is list now. Thanks.

Joel Coehoorn · Accepted Answer · 2013-07-26 16:57:44Z

2

This code is .Net 2.0 safe:

public static string ReadLines(StreamReader input)
{
    string line;
    while ( (line = input.ReadLine()) != null)
       yield return line;
}

private taMibMsftEmpDetails BuildLine(string EmpId, string EmpName, String ExpnsDate)
{
    taMibMsftEmpDetails empSlNr = new taMibMsftEmpDetails();
    empSlNr.EmployeeId  = EmpId;
    empSlNr.EmployeeName   = EmpName;
    empSlNr.ExpenseDate = ExpnsDate;
    return empSlNr;
}

List<taMibMsftEmpDetails> lineEmpNrs = new List<taMibMsftEmpDetails>();
foreach (string line in ReadLines(HeaderFile))
{
    headerFields = line.Split(',');
    lineEmpNrs.Add(BuildLine(headerFields[1],headerFields[2],headerFields[3]));
}
lineEmpNrs.Sort(delegate(taMibMsftEmpDetails a, taMibMsftEmpDetails a) 
   { 
      return a.EmployeeId.CompareTo(a.EmployeeId); 
   });

If you can get to at least .Net 3.5 (still uses .Net 2.0 runtime), it gets that much simpler:

public static string ReadLines(StreamReader input)
{
    string line;
    while ( (line = input.ReadLine()) != null)
       yield return line;
}

var lineEmpNrs = ReadLines(HeaderFile)
   .Select(l => l.Split(','))
   .Select(l => new taMibMsftEmpDetails() 
       {
          EmployeeId   = l[1],
          EmployeeName = l[2],
          ExpenseDate  = l[3]
       })
   .OrderBy(l=> l.EmployeeId)
   .ToList();

answered Jul 26, 2013 at 16:57

Joel Coehoorn

418k114 gold badges582 silver badges820 bronze badges

1 Comment

Anirudh Over a year ago

I am looking to find out record count based on employee. for example, empA record count is 99 and empB record count is 50 and so on. I had used this with Arraylist but want to know which option in LIST has this feature. Is GroupBy doable to acheive what I am looking for? Thanks.

Garrison Neely · Accepted Answer · 2013-07-26 16:45:40Z

2

As pointed out below, this won't work on ArrayList, but you could convert lineEmpNrs to a List<taMibMsftEmpDetails>.

LINQ is perfect here.

var sortedList = lineEmpNrs.OrderBy(emp => emp.EmployeeId);

After seeing your comment, this will only work if you can bump your code from .NET 2.0 to 3.5 or higher.

edited Jul 26, 2013 at 16:45

answered Jul 26, 2013 at 16:33

Garrison Neely

3,2893 gold badges29 silver badges39 bronze badges

6 Comments

Garrison Neely Over a year ago

heh, saw the folly as soon as I hit the submit answer button. Thanks guys.

Rameez Ahmed Sayad Over a year ago

ArrayList doesn't I believe

MethodMan Over a year ago

emp is a variable you could name it anything you like look up lambda expressions when you get an opportunity

Garrison Neely Over a year ago

As @DJKRAZE mentions, yes, do some research into Lambda expressions. It's a placeholder variable that represents one item in the list of items that you are iterating through to order.

Anirudh Over a year ago

@GarrisonNeely: I don't get to see orderby when I type lineEmpNrs. What am I missing here?

|

Rameez Ahmed Sayad · Accepted Answer · 2013-07-26 16:44:39Z

1

You can use the ArrayList as a List

var enumerableCollection = from taMibMsftEmpDetails ln in lineEmpNrs
                                        orderby ln.EmployeeId
                                        select ln;

You can convert to Array or use the List

answered Jul 26, 2013 at 16:44

Rameez Ahmed Sayad

1,3006 gold badges16 silver badges30 bronze badges

Comments

jiverson · Accepted Answer · 2013-07-26 16:52:21Z

You can also load the data in to a DataTable and sort via a DataView.

    DataTable dt = new DataTable();
    dt.Columns.Add("EmpID");
    dt.Columns.Add("Field2");
    dt.Columns.Add("Field3");

    // Read file, split values, add to table
    while (!HeaderFile.EndOfStream) {

        headerRow  = HeaderFile.ReadLine();
        headerFields = headerRow.Split(',');

        // Create row and add it to the table
        DataRow dr = dt.NewRow();
        dr["EmpID"] = headerFields[0];
        dr["Field1"] = headerFields[1];
        dr["Field2"] = headerFields[2];
        dt.ImportRow(dr);
    }

    // Sort table by EmpID
    DataView dv = dt.DefaultView;
    dv.Sort = "EmpID ASC";
    dt = dv.ToTable();

webarchitect · Accepted Answer · 2013-07-26 18:15:30Z

1

The regular sort method should work alongside a custom compare method, something like the following:

private class sortByEmployeeIdHelper: IComparer
{
   int IComparer.Compare(object a, object b)
   {
       taMibMsftEmpDetails employeeA = (taMibMsftEmpDetails)a;
       taMibMsftEmpDetails employeeB = (taMibMsftEmpDetails)b;

       //employee id is numeric?
       int id = int.Parse(employeeA.EmployeeId);
       return id.CompareTo(int.Parse(employeeB.EmployeeId));
   }
}

IComparer myComparer = new sortByEmployeeIdHelper();
lineEmpNrs.Sort(myComparer);

edited Jul 26, 2013 at 18:15

answered Jul 26, 2013 at 18:09

webarchitect

944 bronze badges

Collectives™ on Stack Overflow

Arraylist sorting in c#

6 Answers 6

1 Comment

1 Comment

6 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

1 Comment

1 Comment

6 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related