Reading array from file

Question

I have next code in php

<?
$stop_ips_masks = array(
        "66\.249\.[6-9][0-9]\.[0-9]+", 
        "74\.125\.[0-9]+\.[0-9]+", 
    );
foreach ( $stop_ips_masks as $k=>$v )
{
    if ( preg_match( '#^'.$v.'$#', $_SERVER['REMOTE_ADDR']) )
        echo found;
}
?>

and it works fine. But I would like to load this array from txt file, so I wrote code

<?
$stop_ips_masks = file('array.txt');
foreach ( $stop_ips_masks as $k=>$v )
{
    if ( preg_match( '#^'.$v.'$#', $_SERVER['REMOTE_ADDR']) )
        echo found;
}
?>

where array.txt is

"66\.249\.[6-9][0-9]\.[0-9]+",
"74\.125\.[0-9]+\.[0-9]+",

and this code doesn't work. Please help me what is wrong with my code?

Will your strings have any newlines or other special characters embedded in them? — Raceimaztion
– Raceimaztion, Commented Jul 27, 2013 at 8:00
Yes, I will add later more lines the same type like in example. — Max
– Max, Commented Jul 27, 2013 at 9:36
Is your file in the same directory as the one you run the script from? Try using absolute path. Also, the commas at the end of each line and the quotes may spoil your script. And remember - check the error log ;) — core1024
– core1024, Commented Jul 27, 2013 at 17:09

DevZer0 · Accepted Answer · 2013-07-27 07:59:01Z

1

you need to convert your text into array first, because what your doing right now includes a , in your regexp pattern

$stop_ips_masks = file_get_contents('array.txt');
$stop_ips_masks = explode("," $stop_ips_masks);

You might also need to do a trim operation and remove the newlines as well. it would be easier if you stick to one record separator. like comma or newline. not both.

If you remove the , from your text file then you can do

$stop_ips_masks = file('array.txt');

answered Jul 27, 2013 at 7:59

DevZer0

13.5k7 gold badges29 silver badges54 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Max Over a year ago

Also doesn't work, I think that problem maybe is in slashes but don't know how to solve it.

Alfred · Accepted Answer · 2013-07-27 16:15:59Z

0

Try something like;

<?
$file = file('array.txt');
$stop_ips_masks = explode(",",$file);
foreach ( $stop_ips_masks as $k=>$v )
{
    if ( preg_match( '#^'.$v.'$#', $_SERVER['REMOTE_ADDR']) )
        echo found;
}
?>

answered Jul 27, 2013 at 16:15

Alfred

21.5k64 gold badges175 silver badges258 bronze badges

Comments

Orangepill · Accepted Answer · 2013-07-27 17:50:13Z

0

I believe your issue is the quotes and tailing comma. While needed to make a array in php they are invalid when sourced from the file.

    $stop_ips_masks = file('array.txt', FILE_IGNORE_NEWLINES);
    foreach ( $stop_ips_masks as $k=>$v )
    {
          $v = trim(rtrim($v, ","), '"');
          if ( preg_match( '#^'.$v.'$#', $_SERVER['REMOTE_ADDR']) )
          echo found;
    }

edited Jul 27, 2013 at 17:50

answered Jul 27, 2013 at 8:06

Orangepill

24.7k3 gold badges44 silver badges64 bronze badges

Comments

Raceimaztion · Accepted Answer · 2013-07-28 00:54:20Z

0

Another option is to store your strings "raw" in the file as lines:

66\.249\.[6-9][0-9]\.[0-9]+
74\.125\.[0-9]+\.[0-9]+

Then read the file, putting each line into the array:

$array = file('array.txt');

edited Jul 28, 2013 at 0:54

answered Jul 27, 2013 at 16:02

Raceimaztion

9,6745 gold badges29 silver badges41 bronze badges

1 Comment

core1024 Over a year ago

Or just $array = file('array.txt') as it's the same ;)

Collectives™ on Stack Overflow

Reading array from file

4 Answers 4

1 Comment

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related