Why is this Javascript code executed twice?

Question

When a link is clicked on my site the Javascript code below is executed, if the condition is true it will display an alert dialog. When the user selects the OK button in the alert dialog the block of code is executed again.

So the alert closes, the code below is executed for a second time and the alert dialog is displayed again. When the used selects the OK button on the alert dialog the second time the alert dialog is closed for good.

How can I prevent the code below being executed twice?

$("#my-button").click(function() {
    var login = someVar;
    if(!someVar || someVar == ''){
        $('.close-reveal-modal').click(); 
        alert(myMessage);
    }
});

Does #my-button also have a class of .close-reveal-modal, by any chance? — Jamie Burns
– Jamie Burns, Commented Jul 31, 2013 at 10:31
@evilbhonda - wouldn't that send it into an infinite loop of alerts? — RobH
– RobH, Commented Jul 31, 2013 at 10:35
@RobH maybe, I'd need to check. But from the limited code that's provided, that's the part that jumped out at me — Jamie Burns
– Jamie Burns, Commented Jul 31, 2013 at 10:37

Sergio · Accepted Answer · 2013-07-31 16:41:30Z

1

Check if you are adding the click handler twice, maybe that is what is causing that behavior.

In that case remove one of them.

answered Jul 31, 2013 at 16:41

Sergio

28.9k11 gold badges90 silver badges132 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Nirav Zaveri · Accepted Answer · 2013-07-31 10:50:57Z

1

From the very limited information that's provided, this is all that I can think of as going wrong:

$('.close-reveal-modal').click();

This piece of code should have some kind of function which is executed to display a similar Alert Box.

A complete code would be more useful for a complete answer!

answered Jul 31, 2013 at 10:50

Nirav Zaveri

7171 gold badge9 silver badges28 bronze badges

Comments

mmarkel · Accepted Answer · 2018-11-07 07:29:19Z

1

Might not have anything to do with that code at all. Check to make sure that your javascript file isn't being called twice in the same app.

answered Nov 7, 2018 at 7:29

mmarkel

111 bronze badge

Comments

Maxime Lorant · Accepted Answer · 2013-07-31 11:04:00Z

0

From what we have here, I'm guessing that your .close-reveal-modal element is in #my-button (or is the same html node).

When you trigger the click on it (by $('.close-reveal-modal').click();), it also trigger the click on its parent node, so on #my-button too.

I can be wrong, we need the HTML part (a fiddle would be great) to validate my theory.

answered Jul 31, 2013 at 11:04

Maxime Lorant

36.4k19 gold badges91 silver badges97 bronze badges

Collectives™ on Stack Overflow

Why is this Javascript code executed twice?

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related