Call one function from another function in PHP class

Question

I want to scan directories and subdirectories, make list of xml files, take content from xml files and display it. This functions work correctly without OOP. I try to create a class. I call function scandir_through from function main. I haven't errors, result too.

class data {
    var $dir = 'D:\wamp4\www\begin';

    public function scandir_through($dir)
     {
         $items = glob($dir . '/*');
         for ($i = 0; $i < count($items); $i++) {
             if (is_dir($items[$i])) {
                 $add = glob($items[$i] . '/*');
                 $items = array_merge($items, $add);
             }
         }
        return $items;
     }

    public function main()
    {
        $scan_tree = $this->scandir_through($dir);
        echo "<ul id='booklist'>"."</n>";
        foreach ($scan_tree as $key=>$file){
            $url = $file;
            $xml = simplexml_load_file($url);  
               $book_count = count($xml->book); 
               for($i = 0; $i < $book_count; $i++) { 
                   $book = $xml->book[$i]; 
                   $title=$xml->book[$i]->title;
                   $author=$xml->book[$i]->author;
                   //echo '</br>';
                   //echo $file. " &nbsp   ";
                   //echo $title. " &nbsp   ";
                   //echo $author;
                   echo "<li><div class='file'>".$file."</div>
                   <div class='title'>".$title."</div>
                   <div class='author'>".$author."</div></li></n>";
               }     
         }  
          echo "</ul>";
    }
}
$d = new data();
$d->main();
?>

Please remember that PHP is a multi-paradigm language. You don't need to use OOP everywhere. — lsouza
– lsouza, Commented Aug 8, 2013 at 17:56

John Parker · Accepted Answer · 2013-08-08 18:01:18Z

20

The problem is because the $dir instance variable isn't what you're accessing within your main method. (It's looking for a $dir variable in the scope of that method, rather than at the class level.)

What you need to use is...

$scan_tree = $this->scandir_through($this->dir);

If you turn on E_NOTICE warnings, you'll see that it'll have been throwing an error.

answered Aug 8, 2013 at 18:01

John Parker

54.5k11 gold badges133 silver badges131 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

vili Over a year ago

I was tryed this, but I have a blank page, no result.

user1522901 · Accepted Answer · 2013-08-08 18:16:15Z

3

I think that $dir should be an argument for main. Just think if you had nothing else in the class, where would main get $dir from?

I would change:

public function main()

to

public function main($dir)

and when you call main using $d, include the dir so change that to:

$d->main($dir);

answered Aug 8, 2013 at 18:16

user1522901

1098 bronze badges

1 Comment

user1522901 Over a year ago

@vili if $d->main($dir) doesn't work try it without since you already have the $dir in the class.

Michael Irigoyen · Accepted Answer · 2015-05-06 19:02:30Z

1

$items=data::scandir_through($dir);

edited May 6, 2015 at 19:02

Michael Irigoyen

23.1k18 gold badges92 silver badges132 bronze badges

answered May 6, 2015 at 16:28

Pichitron

1675 bronze badges

Collectives™ on Stack Overflow

Call one function from another function in PHP class

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related