insert multiple fields using foreach loop

Question

I have a problem when I want to insert multiple fields into one table.

Here's my form:

<h1>Add user</h1>
 <form method="post" action="index.php">

 <table>
    <thead>
        <th>Name</th>
        <th>Age</th>
    </thead>

    <tr>
        <td><input name="name[]" type="text" /></td>
        <td><input name="age[]" type="text" /></td>
    </tr>

    <tr>
        <td><input name="name[]" type="text" /></td>
        <td><input name="age[]" type="text" /></td>
    </tr>

    <tr>
        <td><input name="name[]" type="text" /></td>
        <td><input name="age[]" type="text" /></td>
    </tr>
</table>

 <input type="submit" name="submit" value="Submit" />
 </form>

And here's the submit code:

if (isset($_POST['submit'])) {

    foreach ($_POST as $val) {
        $name = $val['name'];
        $age = $val['age'];

        mysql_query("INSERT INTO users (name, age) VALUES ('$name', '$age')");
    } 
}

The query inserts into the database, but not the values that I've entered.

Can someone please help me?

SQL injection anyone?

Mike
– Mike

2013-08-09 22:27:49 +00:00
Commented Aug 9, 2013 at 22:27 — Mike
– Mike, Commented Aug 9, 2013 at 22:27
yeah, I'll fix that later, just need to fix this right now

Kim Andersson
– Kim Andersson

2013-08-09 22:28:56 +00:00
Commented Aug 9, 2013 at 22:28 — Kim Andersson
– Kim Andersson, Commented Aug 9, 2013 at 22:28

Mike Brant · Accepted Answer · 2015-08-24 19:58:58Z

15

You are doing a foreach on $_POST rather than on the name/age arrays. You should be doing foreach on name or age array like this:

if (
   !empty($_POST['name']) && !empty($_POST['age']) &&
   is_array($_POST['name']) && is_array($_POST['age']) &&
   count($_POST['name']) === count($_POST['age'])
) {
    $name_array = $_POST['name'];
    $age_array = $_POST['age'];
    for ($i = 0; $i < count($name_array); $i++) {

        $name = mysql_real_escape_string($name_array[$i]);
        $age = mysql_real_escape_string($age_array[$i]);

        mysql_query("INSERT INTO users (name, age) VALUES ('$name', '$age')");
    } 
}

I would also note that you are currently susceptible to SQL injection so I added the step of escaping your strings for name/age.

I would also highly suggest simply making a single bulk insert into the DB instead of an insert of each record individually (I will leave that up to you to implement). This approach is almost always preferable from a performance standpoint.

Finally, you REALLY should not be using mysql_* functions as they are deprecated. Consider changing to mysqli or PDO.

edited Aug 24, 2015 at 19:58

answered Aug 9, 2013 at 22:33

Mike Brant

71.4k10 gold badges102 silver badges104 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

yaqoob Over a year ago

Thanks. but i'm having issues with the solution.

Mr.Web · Accepted Answer · 2017-09-14 09:09:03Z

5

if (isset($_POST['submit'])) {

$i = 0;
foreach ($_POST as $val) {
    $name = $_POST['name'][$i];
    $age = $_POST['age'][$i];

    mysql_query("INSERT INTO users (name, age) VALUES ('$name', '$age')");
    $i++;
  } 
}

This will solve your problem !

edited Sep 14, 2017 at 9:09

Mr.Web

7,2078 gold badges56 silver badges90 bronze badges

answered Aug 9, 2013 at 22:39

Rahul

1,1691 gold badge11 silver badges21 bronze badges

Comments

Danilo Corrente Luiz · Accepted Answer · 2018-01-22 18:28:22Z

1

foreach($_POST['firstname'] as $key=>$value) {
    $firstname = $_POST['firstname'][$key];
    $lastname = $_POST['tipo'][$key];
    echo "Parte: $lastname";
    echo "<br>"; 
    echo "Tipo: $firstname";
    echo "<br>";
}

answered Jan 22, 2018 at 18:28

Danilo Corrente Luiz

111 bronze badge

1 Comment

Goose Over a year ago

You should add explanation for your answer to help OP and other readers understand this solution. Code only answers are discouraged.

Shivaram Mahapatro · Accepted Answer · 2015-10-03 05:36:51Z

0

A little bit easier code which works for me well.

if (isset($_POST['submit'])) {
     $i = 0;
     for ((array) $_POST as $val) {
       $sql = "INSERT INTO users (name, age) VALUES (
                   '{$_POST["name"][$i]}','{$_POST["age"][$i]}'
               );
       mysql_query($sql);
       echo (!mysql_affetced_rows()) ? "Query Wrong" : "Query Okay";
       $i++;
     } 
    }

answered Oct 3, 2015 at 5:36

Shivaram Mahapatro

12511 bronze badges

Comments

jitendra parmar · Accepted Answer · 2016-02-06 09:20:38Z

0

below is the fxample how to inset multi row at one time

$query_string = "INSERT INTO YOURTBL_NAME(column_1,column_2)VALUES";
    $data ="";
    for($i=0;$i<count($YOUR FILE ARRAY);$i++)
    {
        $data .='("'.$paramater_1[$i].'","'.$paramater_2.'"),';
    }
     $qry = substr($query_string.$data, 0, -1); 
     $result = mysql_query($qry);

answered Feb 6, 2016 at 9:20

jitendra parmar

1501 silver badge7 bronze badges

Comments

Pankaj Upadhyay · Accepted Answer · 2016-07-24 07:56:25Z

$education_institute_array = $_POST['education_institute'];
        $education_qualification_array = $_POST['education_qualification'];
        $education_start_date_array = $_POST['education_start_date'];
        $education_end_date_array = $_POST['education_end_date'];
        $education_note_array = $_POST['education_note'];
        for ($i = 0; $i < count($education_institute_array); $i++) {
            $education_institute = mysql_real_escape_string($education_institute_array[$i]);
            $education_qualification = mysql_real_escape_string($education_qualification_array[$i]);
            $education_start_date = mysql_real_escape_string($education_start_date_array[$i]);
            $education_end_date = mysql_real_escape_string($education_end_date_array[$i]);
            $education_note = mysql_real_escape_string($education_note_array[$i]);
            $sql_education_insert = "INSERT INTO `education` (`user_id`, `education_institute`, `education_qualification`, `education_start_date`, `education_end_date`, `education_note`) VALUES ('$user_id', '$education_institute', '$education_qualification', '$education_start_date', '$education_end_date', '$education_note')";
            $sql_result_education = mysql_query($sql_education_insert);
        }

Collectives™ on Stack Overflow

insert multiple fields using foreach loop

6 Answers 6

1 Comment

Comments

1 Comment

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

1 Comment

Comments

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related