Change value of element inside iframe after onclick event with javascript

Question

I have some elements inside an iframe with an onclick event associated, something like:

<iframe>
 ... 
    <input type="text" onclick="somefunction(this)"/>
 ...
</iframe>

In the function called I try to change the value of the input, nothing special:

{
...
foo.value = "changed!"
...
}

At this point I can see in firebug that the value has changed but when the function finish the value doesn't change at all.

The same kind of thing with an onmouseover seems to work.

Any ideas?

Thanks.

Edit: Change code mistake

Quentin · Accepted Answer · 2009-11-30 12:57:48Z

1

'this' means different things in the different contexts

Given:

<input type="text" onclick="somefunction(this)"/>

'this' is the input (since it is called as myInput.onclick())

But:

function someFunction(foo) {
    this.value;
}

You are calling as:

someFunction(myInput)

which is the same as

window.someFunction(myInput)

So in that context, 'this' is the window object.

Use 'foo' instead (since that is the argument name in the function declaration).

answered Nov 30, 2009 at 12:57

Quentin

949k136 gold badges1.3k silver badges1.4k bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

MarcosPri Over a year ago

You are completely right, but I made that mistake while writing the question here, is correct in the actual code.

antesima · Accepted Answer · 2009-11-30 13:01:19Z

0

Value is not defined for an iframe tag. In Javascript, the "value" member is merely added to the object when set, but of course not taken into account by the navigator.

For setting content (this is also the case for div), you should use :

this.innerHTML = "Changed!";

or

this.innerText = "Changed!";

answered Nov 30, 2009 at 13:01

antesima

231 bronze badge

2 Comments

Quentin Over a year ago

The question is about an input inside an iframe, not the iframe itself (although, frankly, the iframe is a red herring).

MarcosPri Over a year ago

Thank you. But I actually want to change the input inside the iframe, not the iframe itself.

Collectives™ on Stack Overflow

Change value of element inside iframe after onclick event with javascript

2 Answers 2

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related