Database Insertion error due to query

Question

I have a new database.I want to insert manual values and picking table name from a database. But it shows an error.The following code i use.My row values are first one is a String and following are Integers(here=fcltyname is the only String)

 connection = (Connection) dbSource.getConnection();
        String qry = "SELECT studentName From batcha "; 
        System.out.println(fcltyName);

        stmt = (PreparedStatement)  connection.prepareStatement(qry);
            rs =  stmt.executeQuery();

            while (rs.next()) {

                String check=new String(rs.getString(("studentName")));
                String student = check.replaceAll("\\s","");

                Class.forName("com.mysql.jdbc.Driver");
                connection = (Connection) DriverManager.getConnection(DB_URL_table, USER, PASS);

                String sql1 = "INSERT IGNORE INTO "+student+" (fcltyName,CommunicationOral,Communicationwritten,Leadership,AnalyticalAbilities,Interpersonalskills,DecisionMakingSkills,SelfConfidence,Creativity,Punctualityregularity,GeneralAwareness,Commitment,HardWork)VALUES("+fcltyName+",0,0,0,0,0,0,0,0,0,0,0,0)"; 

                newStmt=(PreparedStatement) connection.prepareStatement(sql1); 

            newStmt.executeUpdate(sql1); 

            newStmt.close();

Error

 com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '0,0,0,0,0,0,0,0,0,0,0,0)' at line 1

You have to wrap fcltyName with simple quotes: VALUES('"+fcltyName+"'... — M Abbas
– M Abbas, Commented Aug 14, 2013 at 11:10

Suresh U · Accepted Answer · 2013-08-14 11:19:01Z

Try this once

'

    try {
        String insertTableSQL = "INSERT INTO DBUSER"+ "fcltyName,CommunicationOral,Communicationwritten,Leadership,AnalyticalAbilities,Interpersonalskills,DecisionMakingSkills,SelfConfidence,Creativity,Punctualityregularity,GeneralAwareness,Commitment,HardWork) VALUES"+ "(?,?,?,?,?,?,?,?,?,?,?,?,?)";

        dbConnection = getDBConnection();
        preparedStatement = dbConnection.prepareStatement(insertTableSQL);

        preparedStatement.setStringt(1, fcltyName);
        preparedStatement.setInt(2, 0);
        preparedStatement.setInt(3, 0);
        preparedStatement.setInt(4,0);
        preparedStatement.setInt(5, 0);
        preparedStatement.setInt(6, 0);
        preparedStatement.setInt(7,0);
        preparedStatement.setInt(8, 0);
        preparedStatement.setInt(9, 0);
        preparedStatement.setInt(10,0);
        preparedStatement.setInt(11, 0);
        preparedStatement.setInt(12, 0);
        preparedStatement.setInt(13,0);

        // execute insert SQL stetement
        preparedStatement.executeUpdate();}'

Rajendra_Prasad · Accepted Answer · 2013-08-14 11:12:27Z

1

try this one

String sql1 = "INSERT IGNORE INTO "+student+" (fcltyName,CommunicationOral,Communicationwritten,Leadership,AnalyticalAbilities,Interpersonalskills,DecisionMakingSkills,SelfConfidence,Creativity,Punctualityregularity,GeneralAwareness,Commitment,HardWork)VALUES('"+fcltyName+"',0,0,0,0,0,0,0,0,0,0,0,0)";

answered Aug 14, 2013 at 11:12

Rajendra_Prasad

1,3024 gold badges18 silver badges36 bronze badges

1 Comment

jontro Over a year ago

I would not recommend inserting values like this. It is prone to sql injection and the queries cannot be cached.

SpringLearner · Accepted Answer · 2013-08-14 11:12:59Z

1

I think fcltyName is a varchar type so you need to insert it within 'fcltyName'

String sql1 = "INSERT IGNORE INTO "+student+" (fcltyName,CommunicationOral,Communicationwritten,Leadership,AnalyticalAbilities,Interpersonalskills,DecisionMakingSkills,SelfConfidence,Creativity,Punctualityregularity,GeneralAwareness,Commitment,HardWork)VALUES("+"'"+fcltyName+"'"+",0,0,0,0,0,0,0,0,0,0,0,0)";

answered Aug 14, 2013 at 11:12

SpringLearner

13.9k20 gold badges82 silver badges117 bronze badges

2 Comments

SpringLearner Over a year ago

@DeepthiDipin string in java but varchar in sql

SpringLearner Over a year ago

@DeepthiDipin as suresh has said,try to use preparedstatement always

jontro · Accepted Answer · 2013-08-14 11:06:15Z

0

Do not insert values directly in the query, use a preparedstatment and feed the values as arguments.

See http://www.mkyong.com/jdbc/jdbc-preparestatement-example-insert-a-record/ for an example

answered Aug 14, 2013 at 11:06

jontro

10.7k6 gold badges49 silver badges71 bronze badges

Collectives™ on Stack Overflow

Database Insertion error due to query

4 Answers 4

Comments

1 Comment

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

1 Comment

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related