Javascript: Adding comma to number

Question

When the number reaches 1000 it adds the comma and becomes like so 1,000 although once it implements the ',' it then resets back to 12 where it should carry on.

Here is my jsFiddle: http://jsfiddle.net/m9cey/3/

var millisecs = 1000;
setInterval(function() {
    var $badge = $('#badge');
    var num = parseInt($badge.text())+11;
    $badge.text(num.toString().replace(/\B(?=(\d{3})+(?!\d))/g, ","));
}, millisecs);

Any help will be much appreciated.

Cheers

I would suggest separating the value and the output. That way you're not trying to parse text to a number and then converting it back. Store the value as data, and then output the stringified value to the DOM. jsfiddle.net/m9cey/10 — ArrayKnight
– ArrayKnight, Commented Aug 14, 2013 at 23:27
Working as expected. parseInt will parse up to -- BUT NOT INCLUDING -- the comma. The documentation for parseInt will help you a lot. — Jeremy J Starcher
– Jeremy J Starcher, Commented Aug 14, 2013 at 23:30

ArrayKnight · Accepted Answer · 2013-08-14 23:31:40Z

2

Just posting my comment as an answer: http://jsfiddle.net/m9cey/10/

<span id="badge" data-value="900">900</span>

setInterval(function() {
    var $badge = $('#badge'),
        num = parseFloat($badge.data('value'));

    num += 11;

    $badge
        .data('value', num)
        .text(num.toString().replace(/\B(?=(\d{3})+(?!\d))/g, ","));
}, millisecs);

answered Aug 14, 2013 at 23:31

ArrayKnight

7,4264 gold badges19 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Musa · Accepted Answer · 2013-08-14 23:28:15Z

1

The , in the value is causing parseInt to stop at it. So parseInt('1,xxx') will give you 1 then add eleven to it you get 12 .

Easiest solution remove the comma before parseInt

var num = parseInt($badge.text().replace(',', ''))+11;

http://jsfiddle.net/m9cey/9/

answered Aug 14, 2013 at 23:28

Musa

97.9k17 gold badges123 silver badges144 bronze badges

3 Comments

tebrown Over a year ago

Thanks Musa this works perfect. Cheers for the fast response. Will tick asap.

dc5 Over a year ago

If your numbers can get really big you need to replace globally

tebrown Over a year ago

Going on from this topic, i'm trying to make it so that it goes up $11.43 per second. So ideally, I need to remove the .00 and include the 43 somehow? Any help would be great!

Roseann Solano · Accepted Answer · 2013-08-14 23:25:00Z

1

Have you heard of numerals.js?

var string = numeral(1000).format('0,0');
// '1,000'

answered Aug 14, 2013 at 23:25

Roseann Solano

7682 gold badges8 silver badges13 bronze badges

1 Comment

tebrown Over a year ago

Yup I had looked at that but then got lead onto something else!. Thanks though!

Collectives™ on Stack Overflow

Javascript: Adding comma to number

3 Answers 3

Comments

3 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

3 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related