My JavaScript code is not able to read the JSON generated by my PHP code. What is wrong?

Question

I'm using AJAX call and I'm generating this JSON object which is sent back to JavaScript. When I receive it in the JavaScript I'm not able to get values from it.

PHP:

echo json_encode(array("results" => array(array("user" => $member['user']),array("company" => $member['company']))));

JS:

success: function(response) 
    {
        for(var i = 0;i < response.results.length; i++)
        {   
          sessionStorage.setItem('user',response.results[i].user);
          sessionStorage.setItem('company',response.results[i].company);
        }
    }

I'm not able to read any values from the response that I receive.

Response that I get is in this format:

{"results":[{"user":"David"},{"company":"something"}]}

What would be the proper way of reading this JSON object?

You need the json to format like this {"results":[{"user":"David", "company":"something"}]} — zs2020
– zs2020, Commented Aug 15, 2013 at 19:47
Are you getting errors or is the for loop never executing or what is the problem? — Evan Davis
– Evan Davis, Commented Aug 15, 2013 at 19:48
@Blazemonger According to his code, he may have multiple items like {"results":[{"user":"David", "company":"something"}, {"user":"D", "company":"S"}]} — zs2020
– zs2020, Commented Aug 15, 2013 at 19:50
You might have to parse the JSON first, unless you set the correct content type response headers or have the dataType: 'json' option in the Ajax call. — Felix Kling
– Felix Kling, Commented Aug 15, 2013 at 20:02

kaan_atakan · Accepted Answer · 2013-08-15 20:31:30Z

2

Since you are trying to access results[0].company and results[1].user which are undefined, and since only results[1].company and results[0].user are defined in your object, if you change your PHP as follows your JavaScript should work unless response is just a string:

echo json_encode( array(
    "results" => array(
        array(
            "user" => $member['user'],
            "company" => $member['company']
        )
     )
));

If response is just a string change your JavaScript code as follows:

success: function(response) 
{
    response = JSON.parse(response);

Or

dataType: "json",
success: function(response) 
{

edited Aug 15, 2013 at 20:31

answered Aug 15, 2013 at 19:58

kaan_atakan

4,1071 gold badge37 silver badges66 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

user123_456 Over a year ago

how do I access it in JS

user123_456 Over a year ago

I'm getting: TypeError: Cannot read property 'length' of undefined

Felix Kling Over a year ago

@user123_456: Add dataType: 'json' to your Ajax options. Otherwise response is a string containing JSON, not an object.

kaan_atakan Over a year ago

That's strange. Could you post the contents of response or typeof response? If it's a string you can also do response = JSON.parse(response); or what Felix said.

aperl · Accepted Answer · 2013-08-15 20:39:35Z

0

In your JSON response your result contains an array with 2 objects. The first containing the user and the second containing the company. However, the your for loop you expect both elements in the array to have both user and company. It looks like you are trying to just send one user and their company. If that is the case then your code should be as follows:

PHP:

echo json_encode(array("results" => array("user" => $member['user'],"company" => $member['company'])));

JS:

success: function(response) 
    {
        sessionStorage.setItem('user',response.results.user);
        sessionStorage.setItem('company',response.results.company);
    }

Your response will look like this.

{"results":{"user":"David","company":"something"}}

edited Aug 15, 2013 at 20:39

answered Aug 15, 2013 at 19:58

aperl

1443 bronze badges

1 Comment

aperl Over a year ago

Sorry I accidentally left part of the old code on the PHP side. With the new edits it should now work.

Collectives™ on Stack Overflow

My JavaScript code is not able to read the JSON generated by my PHP code. What is wrong?

2 Answers 2

4 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related