MySQL/Java error

Question

Newbie programmer here. Upon doing mvn tomcat:run I get the following error:

SEVERE: Servlet.service() for servlet appServlet threw exception
com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: You have an error in your SQL  syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'values (?, ?)' at line 1

The code in question is as follows:

public void create(User user) {
    this.jdbcTemplate.update("INSERT INTO xyz.user(user_name, user_password values (?, ?)");


            user.getUserName(); user.getId();

}

public void delete(User user) {
    this.jdbcTemplate.update("DELETE FROM xyz.user WHERE id = ?");


}

public void update(User user) {
    this.jdbcTemplate.update(
            "UPDATE xyz.user SET UserName = ? password = ? WHERE id = ?");

Googled - couldn't find a solution for (?, ?) scenarios. Pls. help - Thx in advance :)

Here's the complete code (almost) - I am doing something wrong but can't figure out what.

public User find(String login) {
  System.out.println("Trying to find the user...." + login);    
  User user = this.jdbcTemplate.queryForObject(
        "select * from xyz where user_name = ?",
        new Object[]{login},
        new RowMapper<User>() {
            public User mapRow(ResultSet rs, int rowNum) throws SQLException {
                User user = new User();
                user.setId(Long.valueOf(rs.getInt(1)));
                user.setUserName(rs.getString(2));
                user.setPassword(rs.getString(3));
                return user;
            }
        });
  System.out.println("Found user..." + user);
   return user;
}

public void create(User user) {

    this.jdbcTemplate.update("INSERT INTO ibstechc_dev.user(user_name, user_password) VALUES (?,?)");

            user.getUserName(); user.getId() ;
}


public void delete(User user) {
    this.jdbcTemplate.update("DELETE FROM xyz WHERE id = ?");
    // TODO Auto-generated method stub

}

public void update(User user) {
    this.jdbcTemplate.update(
            "UPDATE xyz SET user_name = ?, user_password = ? WHERE id = ?");
    // TODO Auto-generated method stub

}

}

I am stuck with the same error - tomcat:run throws the following -

SEVERE: Servlet.service() for servlet appServlet threw exception

com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '?,?)' at line 1

krishnang · Accepted Answer · 2013-08-19 06:10:58Z

2

Use this code:

    this.jdbcTemplate.update("INSERT INTO xyz.user(user_name, user_password) values (?, ?)");

There was an issue with your SQL statement. To give you perspective you were trying to do:

INSERT INTO xyz.user(user_name, user_password values ('testuser','testpass'))

instead of

INSERT INTO xyz.user(user_name, user_password) values ('testuser','testpass'))

Hope this makes sense?

answered Aug 19, 2013 at 6:10

krishnang

6981 gold badge7 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

askance Over a year ago

The parenthesis -it makes sense. Thanks :) But it throws the same error with tomcat:run. I used the suggested code.

krishnang Over a year ago

You have to provide the values of username and password to the values statement for this statement to execute correctly. Look at this documentation : docs.oracle.com/javase/tutorial/jdbc/basics/…

Juned Ahsan · Accepted Answer · 2013-08-19 06:11:29Z

1

I think here is the sql syntax problem:

INSERT INTO xyz.user(user_name, user_password values (?, ?)

replace this by

INSERT INTO xyz.user(user_name, user_password) values (?, ?);

answered Aug 19, 2013 at 6:11

Juned Ahsan

68.9k12 gold badges101 silver badges138 bronze badges

Comments

SpringLearner · Accepted Answer · 2013-08-19 06:13:03Z

1

There is a sql syntax error in update

public void update(User user) {
    this.jdbcTemplate.update(
            "UPDATE xyz.user SET UserName = ? password = ? WHERE id = ?");

this is not the way to update,give a comma(,) like this

public void update(User user) {
    this.jdbcTemplate.update(
            "UPDATE xyz.user SET UserName = ? ,password = ? WHERE id = ?");

answered Aug 19, 2013 at 6:13

SpringLearner

13.9k20 gold badges82 silver badges117 bronze badges

1 Comment

SpringLearner Over a year ago

@user2480526 you have sql syntax error in insert and update.I have posted only the update part as there already answers for insertion part.You need to change all.

ZeusNet · Accepted Answer · 2013-08-19 06:11:46Z

0

your error is this statement

this.jdbcTemplate.update("INSERT INTO xyz.user(user_name, user_password values (?, ?)");

It should be

this.jdbcTemplate.update("INSERT INTO xyz.user(user_name, user_password) values (?, ?)");

Hope it helps

Cheers

answered Aug 19, 2013 at 6:11

ZeusNet

7209 silver badges25 bronze badges

Comments

Rahul Tripathi · Accepted Answer · 2013-08-19 06:12:13Z

0

Try this:-

this.jdbcTemplate.update("INSERT INTO xyz.user(user_name, user_password) values (?, ?)");

instead of

this.jdbcTemplate.update("INSERT INTO xyz.user(user_name, user_password values (?, ?)");

answered Aug 19, 2013 at 6:12

Rahul Tripathi

173k33 gold badges292 silver badges341 bronze badges

Collectives™ on Stack Overflow

MySQL/Java error

5 Answers 5

2 Comments

Comments

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

2 Comments

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related